You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "James Carman (JIRA)" <ji...@apache.org> on 2008/11/15 15:34:44 UTC
[jira] Created: (WICKET-1936) Client-Side Image Map
Client-Side Image Map
---------------------
Key: WICKET-1936
URL: https://issues.apache.org/jira/browse/WICKET-1936
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4-RC1, 1.3.5
Reporter: James Carman
The existing ImageMap implementation does not allow you to "attach" it to any Image component. Also, it only works with Link objects (and thus not AjaxLinks or ExternalLinks). The new client-side image map implementation attaches itself to any existing image and supports any AbstractLink object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1936) Client-Side Image Map
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-1936.
-------------------------------------
Fix Version/s: 1.4.13
1.5-M3
(was: 1.5-M2.1)
Resolution: Fixed
The patch is applied and the new ImageMap implementation is ported to 1.4.x so the users can migrate to the new one before upgrade to 1.5.x
> Client-Side Image Map
> ---------------------
>
> Key: WICKET-1936
> URL: https://issues.apache.org/jira/browse/WICKET-1936
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: James Carman
> Assignee: Martin Grigorov
> Fix For: 1.4.13, 1.5-M3
>
> Attachments: ClientSideImageMape.patch, WICKET-1936.patch
>
>
> The existing ImageMap implementation does not allow you to "attach" it to any Image component. Also, it only works with Link objects (and thus not AjaxLinks or ExternalLinks). The new client-side image map implementation attaches itself to any existing image and supports any AbstractLink object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1936) Client-Side Image Map
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier updated WICKET-1936:
-------------------------------
Attachment: ClientSideImageMape.patch
Implementation using a repeater (and Wicket formatting applied)
> Client-Side Image Map
> ---------------------
>
> Key: WICKET-1936
> URL: https://issues.apache.org/jira/browse/WICKET-1936
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: James Carman
> Assignee: Igor Vaynberg
> Fix For: 1.5-M2.1
>
> Attachments: ClientSideImageMape.patch, WICKET-1936.patch
>
>
> The existing ImageMap implementation does not allow you to "attach" it to any Image component. Also, it only works with Link objects (and thus not AjaxLinks or ExternalLinks). The new client-side image map implementation attaches itself to any existing image and supports any AbstractLink object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-1936) Client-Side Image Map
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reopened WICKET-1936:
-------------------------------------
Assignee: Martin Grigorov (was: Igor Vaynberg)
Reopen to revise the impl and port it to 1.4.x so the users can migrate to the new impl
> Client-Side Image Map
> ---------------------
>
> Key: WICKET-1936
> URL: https://issues.apache.org/jira/browse/WICKET-1936
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: James Carman
> Assignee: Martin Grigorov
> Fix For: 1.5-M2.1
>
> Attachments: ClientSideImageMape.patch, WICKET-1936.patch
>
>
> The existing ImageMap implementation does not allow you to "attach" it to any Image component. Also, it only works with Link objects (and thus not AjaxLinks or ExternalLinks). The new client-side image map implementation attaches itself to any existing image and supports any AbstractLink object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1936) Client-Side Image Map
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Carman updated WICKET-1936:
---------------------------------
Attachment: ClientSideImageMap.patch
Here's the implementation. I'll create test cases and attach a full patch later. I just wanted to get the discussion rolling on the implementation.
> Client-Side Image Map
> ---------------------
>
> Key: WICKET-1936
> URL: https://issues.apache.org/jira/browse/WICKET-1936
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: James Carman
> Attachments: ClientSideImageMap.patch
>
>
> The existing ImageMap implementation does not allow you to "attach" it to any Image component. Also, it only works with Link objects (and thus not AjaxLinks or ExternalLinks). The new client-side image map implementation attaches itself to any existing image and supports any AbstractLink object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1936) Client-Side Image Map
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Carman updated WICKET-1936:
---------------------------------
Attachment: WICKET-1936.patch
Here's the implementation with test cases provided.
> Client-Side Image Map
> ---------------------
>
> Key: WICKET-1936
> URL: https://issues.apache.org/jira/browse/WICKET-1936
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: James Carman
> Fix For: 1.5-M1
>
> Attachments: WICKET-1936.patch
>
>
> The existing ImageMap implementation does not allow you to "attach" it to any Image component. Also, it only works with Link objects (and thus not AjaxLinks or ExternalLinks). The new client-side image map implementation attaches itself to any existing image and supports any AbstractLink object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1936) Client-Side Image Map
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914720#action_12914720 ]
Hudson commented on WICKET-1936:
--------------------------------
Integrated in Apache Wicket 1.5.x #357 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/357/])
> Client-Side Image Map
> ---------------------
>
> Key: WICKET-1936
> URL: https://issues.apache.org/jira/browse/WICKET-1936
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: James Carman
> Assignee: Martin Grigorov
> Fix For: 1.4.13, 1.5-M3
>
> Attachments: ClientSideImageMape.patch, WICKET-1936.patch
>
>
> The existing ImageMap implementation does not allow you to "attach" it to any Image component. Also, it only works with Link objects (and thus not AjaxLinks or ExternalLinks). The new client-side image map implementation attaches itself to any existing image and supports any AbstractLink object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1936) Client-Side Image Map
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649608#action_12649608 ]
James Carman commented on WICKET-1936:
--------------------------------------
I need to fix that patch. The coordinates and type parameters to the Area class are reversed. Either the callers need to change how they're calling it or the parameters need to be switched.
> Client-Side Image Map
> ---------------------
>
> Key: WICKET-1936
> URL: https://issues.apache.org/jira/browse/WICKET-1936
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: James Carman
> Attachments: ClientSideImageMap.patch
>
>
> The existing ImageMap implementation does not allow you to "attach" it to any Image component. Also, it only works with Link objects (and thus not AjaxLinks or ExternalLinks). The new client-side image map implementation attaches itself to any existing image and supports any AbstractLink object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1936) Client-Side Image Map
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1936.
-----------------------------------
Assignee: Igor Vaynberg
Resolution: Fixed
> Client-Side Image Map
> ---------------------
>
> Key: WICKET-1936
> URL: https://issues.apache.org/jira/browse/WICKET-1936
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: James Carman
> Assignee: Igor Vaynberg
> Fix For: 1.5-M2
>
> Attachments: WICKET-1936.patch
>
>
> The existing ImageMap implementation does not allow you to "attach" it to any Image component. Also, it only works with Link objects (and thus not AjaxLinks or ExternalLinks). The new client-side image map implementation attaches itself to any existing image and supports any AbstractLink object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1936) Client-Side Image Map
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914516#action_12914516 ]
James Carman commented on WICKET-1936:
--------------------------------------
Sven Meier, Are you saying you don't like the ClientSideImageMap implementation?
> Client-Side Image Map
> ---------------------
>
> Key: WICKET-1936
> URL: https://issues.apache.org/jira/browse/WICKET-1936
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: James Carman
> Assignee: Igor Vaynberg
> Fix For: 1.5-M2.1
>
> Attachments: ClientSideImageMape.patch, WICKET-1936.patch
>
>
> The existing ImageMap implementation does not allow you to "attach" it to any Image component. Also, it only works with Link objects (and thus not AjaxLinks or ExternalLinks). The new client-side image map implementation attaches itself to any existing image and supports any AbstractLink object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1936) Client-Side Image Map
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914514#action_12914514 ]
Sven Meier commented on WICKET-1936:
------------------------------------
I'd like the current implementation to be revisited:
Building markup in Java code makes this class look like part of a JSP tag library. The attached file does it "the wicket way".
> Client-Side Image Map
> ---------------------
>
> Key: WICKET-1936
> URL: https://issues.apache.org/jira/browse/WICKET-1936
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: James Carman
> Assignee: Igor Vaynberg
> Fix For: 1.5-M2.1
>
> Attachments: WICKET-1936.patch
>
>
> The existing ImageMap implementation does not allow you to "attach" it to any Image component. Also, it only works with Link objects (and thus not AjaxLinks or ExternalLinks). The new client-side image map implementation attaches itself to any existing image and supports any AbstractLink object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1936) Client-Side Image Map
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Carman updated WICKET-1936:
---------------------------------
Attachment: (was: ClientSideImageMap.patch)
> Client-Side Image Map
> ---------------------
>
> Key: WICKET-1936
> URL: https://issues.apache.org/jira/browse/WICKET-1936
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: James Carman
> Fix For: 1.5-M1
>
> Attachments: WICKET-1936.patch
>
>
> The existing ImageMap implementation does not allow you to "attach" it to any Image component. Also, it only works with Link objects (and thus not AjaxLinks or ExternalLinks). The new client-side image map implementation attaches itself to any existing image and supports any AbstractLink object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1936) Client-Side Image Map
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914542#action_12914542 ]
James Carman commented on WICKET-1936:
--------------------------------------
That is more "wickety"! I like it. I've never understood RepeatingViews, so that's why I didn't use them I guess. This seems much cleaner. Although, I don't like that a behavior is named "Area". I'd probably rename it. A behavior does something (i.e. AttributeModifier, etc.) I'd name it something like AddAreaAttributes or something.
> Client-Side Image Map
> ---------------------
>
> Key: WICKET-1936
> URL: https://issues.apache.org/jira/browse/WICKET-1936
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: James Carman
> Assignee: Igor Vaynberg
> Fix For: 1.5-M2.1
>
> Attachments: ClientSideImageMape.patch, WICKET-1936.patch
>
>
> The existing ImageMap implementation does not allow you to "attach" it to any Image component. Also, it only works with Link objects (and thus not AjaxLinks or ExternalLinks). The new client-side image map implementation attaches itself to any existing image and supports any AbstractLink object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1936) Client-Side Image Map
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1936:
----------------------------------
Fix Version/s: 1.5-M2
(was: 1.5-M1)
> Client-Side Image Map
> ---------------------
>
> Key: WICKET-1936
> URL: https://issues.apache.org/jira/browse/WICKET-1936
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: James Carman
> Fix For: 1.5-M2
>
> Attachments: WICKET-1936.patch
>
>
> The existing ImageMap implementation does not allow you to "attach" it to any Image component. Also, it only works with Link objects (and thus not AjaxLinks or ExternalLinks). The new client-side image map implementation attaches itself to any existing image and supports any AbstractLink object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1936) Client-Side Image Map
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1936:
----------------------------------
Fix Version/s: 1.5-M1
> Client-Side Image Map
> ---------------------
>
> Key: WICKET-1936
> URL: https://issues.apache.org/jira/browse/WICKET-1936
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC1
> Reporter: James Carman
> Fix For: 1.5-M1
>
> Attachments: ClientSideImageMap.patch
>
>
> The existing ImageMap implementation does not allow you to "attach" it to any Image component. Also, it only works with Link objects (and thus not AjaxLinks or ExternalLinks). The new client-side image map implementation attaches itself to any existing image and supports any AbstractLink object.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.