You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "chucheng92 (via GitHub)" <gi...@apache.org> on 2023/02/13 09:43:24 UTC
[GitHub] [flink] chucheng92 opened a new pull request, #21915: [FLINK-31015][connectors/common] Fix SplitReader doesn't extend AutoCloseable but implements close method
chucheng92 opened a new pull request, #21915:
URL: https://github.com/apache/flink/pull/21915
## What is the purpose of the change
SplitReader doesn't extend AutoCloseable but implements close method. We need to let it extends AutoCloseable which could enable us to utilize Java's try close feature.
## Brief change log
Let SplitReader interface extends AutoCloseable.
## Verifying this change
Because SplitReader#close override AutoCloseable#close with same signature and behavior. It has no effect on connector implementations. It can be tested by current ci test cases.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 closed pull request #21915: [FLINK-31015][connectors/common] Fix SplitReader doesn't extends AutoCloseable but implements close method
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 closed pull request #21915: [FLINK-31015][connectors/common] Fix SplitReader doesn't extends AutoCloseable but implements close method
URL: https://github.com/apache/flink/pull/21915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org