[GitHub] [pinot] mneedham commented on pull request #9134: Add timestamp index fields to schema for the real-time ingestion path

[GitBox <gi...@apache.org>]

mneedham commented on PR #9134:
URL: https://github.com/apache/pinot/pull/9134#issuecomment-1203688090

   > `TimestampIndexGranularityTest.testTimestampIndexGranularity()` is explicitly checking the lower-case. We may modify the test or keep `TimestampIndexGranularity.isValidTimeGranularity()` handles lower-case. Modify the test might be preferable be avoid people accidentally call `TimestampIndexGranularity.valudOf()` on lower-case granularity string similar to the issue this PR fixed
   
   yeh I think updating the test would make more sense, you're right


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org