You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/10/05 00:02:08 UTC
[GitHub] [incubator-mxnet] sxjscience commented on issue #16355: Embedding
gradient performance optimization on GPU
sxjscience commented on issue #16355: Embedding gradient performance optimization on GPU
URL: https://github.com/apache/incubator-mxnet/pull/16355#issuecomment-538595793
Nice! LGTM. So the BinarySearch version of FindBounds has complexity O(|V| log |N|) where |V| is the vocabulary size and |N| is the number of indices. I guess our initial version has complexity O(|N|) for finding the boundaries. Thus, in some workloads (in which |N| is small), the O(N) version might be faster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services