You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Mark Rappoport (Created) (JIRA)" <ji...@apache.org> on 2012/02/08 21:57:01 UTC

[jira] [Created] (AMQ-3708) Run-time Setting of Destination Prefix

Run-time Setting of Destination Prefix
--------------------------------------

                 Key: AMQ-3708
                 URL: https://issues.apache.org/jira/browse/AMQ-3708
             Project: ActiveMQ
          Issue Type: Improvement
          Components: CMS (C++ client)
    Affects Versions: 5.5.1
         Environment: All
            Reporter: Mark Rappoport
            Priority: Minor
             Fix For: NEEDS_REVIEWED


Some STOMP-aware message brokers (such as HornetQ) want their destinations prefixed in a manner different from "/queue/" or "/topic/". HornetQ, for example, wants it to be "jms.queue." or "jms.topic.".

To address this, I've made some changes to StompHelper, adding the following URI parameters:

* wireFormat.queuePrefix - defaults to "/queue/"
* wireFormat.topicPrefix - defaults to "/topic/"
* wireFormat.tempQueuePrefix - defaults to "/temp-queue/"
* wireFormat.tempTopicPrefix - defaults to "/temp-topic/"

My patch, however, fails to utilize the framework laid out by the StompWireformatProperties class, as the current code structure makes it very hard. Regardless, I've tested it with the SimpleProducer example (make sure you provide guest/guest as auth params if you're running a vanilla HornetQ) and it seems to work fine.

The patch is against the activemq-cpp-3.4.1 tag as trunk wouldn't compile; some formatting issues may be present as well.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Work stopped] (AMQCPP-386) Run-time Setting of Destination Prefix

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQCPP-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on AMQCPP-386 stopped by Timothy Bish.

> Run-time Setting of Destination Prefix
> --------------------------------------
>
>                 Key: AMQCPP-386
>                 URL: https://issues.apache.org/jira/browse/AMQCPP-386
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>          Components: Stomp
>    Affects Versions: 3.3.0, 3.4.0, 3.4.1
>         Environment: All
>            Reporter: Mark Rappoport
>            Assignee: Timothy Bish
>            Priority: Minor
>              Labels: patch
>             Fix For: 3.5.0
>
>         Attachments: stomp-prefixes.patch
>
>
> Some STOMP-aware message brokers (such as HornetQ) want their destinations prefixed in a manner different from "/queue/" or "/topic/". HornetQ, for example, wants it to be "jms.queue." or "jms.topic.".
> To address this, I've made some changes to StompHelper, adding the following URI parameters:
> * wireFormat.queuePrefix - defaults to "/queue/"
> * wireFormat.topicPrefix - defaults to "/topic/"
> * wireFormat.tempQueuePrefix - defaults to "/temp-queue/"
> * wireFormat.tempTopicPrefix - defaults to "/temp-topic/"
> My patch, however, fails to utilize the framework laid out by the StompWireformatProperties class, as the current code structure makes it very hard. Regardless, I've tested it with the SimpleProducer example (make sure you provide guest/guest as auth params if you're running a vanilla HornetQ) and it seems to work fine.
> The patch is against the activemq-cpp-3.4.1 tag as trunk wouldn't compile; some formatting issues may be present as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Moved] (AMQCPP-386) Run-time Setting of Destination Prefix

Posted by "Timothy Bish (Moved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQCPP-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish moved AMQ-3708 to AMQCPP-386:
------------------------------------------

          Component/s:     (was: CMS (C++ client))
                       Stomp
        Fix Version/s:     (was: NEEDS_REVIEWED)
                       3.5.0
    Affects Version/s:     (was: 5.5.1)
                       3.3.0
                       3.4.0
                       3.4.1
                  Key: AMQCPP-386  (was: AMQ-3708)
              Project: ActiveMQ C++ Client  (was: ActiveMQ)
    
> Run-time Setting of Destination Prefix
> --------------------------------------
>
>                 Key: AMQCPP-386
>                 URL: https://issues.apache.org/jira/browse/AMQCPP-386
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>          Components: Stomp
>    Affects Versions: 3.4.1, 3.4.0, 3.3.0
>         Environment: All
>            Reporter: Mark Rappoport
>            Priority: Minor
>              Labels: patch
>             Fix For: 3.5.0
>
>         Attachments: stomp-prefixes.patch
>
>
> Some STOMP-aware message brokers (such as HornetQ) want their destinations prefixed in a manner different from "/queue/" or "/topic/". HornetQ, for example, wants it to be "jms.queue." or "jms.topic.".
> To address this, I've made some changes to StompHelper, adding the following URI parameters:
> * wireFormat.queuePrefix - defaults to "/queue/"
> * wireFormat.topicPrefix - defaults to "/topic/"
> * wireFormat.tempQueuePrefix - defaults to "/temp-queue/"
> * wireFormat.tempTopicPrefix - defaults to "/temp-topic/"
> My patch, however, fails to utilize the framework laid out by the StompWireformatProperties class, as the current code structure makes it very hard. Regardless, I've tested it with the SimpleProducer example (make sure you provide guest/guest as auth params if you're running a vanilla HornetQ) and it seems to work fine.
> The patch is against the activemq-cpp-3.4.1 tag as trunk wouldn't compile; some formatting issues may be present as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AMQ-3708) Run-time Setting of Destination Prefix

Posted by "Mark Rappoport (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Rappoport updated AMQ-3708:
--------------------------------

    Attachment: stomp-prefixes.patch

Patch against tags/activemq-cpp-3.4.1/
                
> Run-time Setting of Destination Prefix
> --------------------------------------
>
>                 Key: AMQ-3708
>                 URL: https://issues.apache.org/jira/browse/AMQ-3708
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: CMS (C++ client)
>    Affects Versions: 5.5.1
>         Environment: All
>            Reporter: Mark Rappoport
>            Priority: Minor
>              Labels: patch
>             Fix For: NEEDS_REVIEWED
>
>         Attachments: stomp-prefixes.patch
>
>
> Some STOMP-aware message brokers (such as HornetQ) want their destinations prefixed in a manner different from "/queue/" or "/topic/". HornetQ, for example, wants it to be "jms.queue." or "jms.topic.".
> To address this, I've made some changes to StompHelper, adding the following URI parameters:
> * wireFormat.queuePrefix - defaults to "/queue/"
> * wireFormat.topicPrefix - defaults to "/topic/"
> * wireFormat.tempQueuePrefix - defaults to "/temp-queue/"
> * wireFormat.tempTopicPrefix - defaults to "/temp-topic/"
> My patch, however, fails to utilize the framework laid out by the StompWireformatProperties class, as the current code structure makes it very hard. Regardless, I've tested it with the SimpleProducer example (make sure you provide guest/guest as auth params if you're running a vanilla HornetQ) and it seems to work fine.
> The patch is against the activemq-cpp-3.4.1 tag as trunk wouldn't compile; some formatting issues may be present as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (AMQCPP-386) Run-time Setting of Destination Prefix

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQCPP-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish resolved AMQCPP-386.
---------------------------------

    Resolution: Fixed

Fixed on trunk.
                
> Run-time Setting of Destination Prefix
> --------------------------------------
>
>                 Key: AMQCPP-386
>                 URL: https://issues.apache.org/jira/browse/AMQCPP-386
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>          Components: Stomp
>    Affects Versions: 3.3.0, 3.4.0, 3.4.1
>         Environment: All
>            Reporter: Mark Rappoport
>            Assignee: Timothy Bish
>            Priority: Minor
>              Labels: patch
>             Fix For: 3.5.0
>
>         Attachments: stomp-prefixes.patch
>
>
> Some STOMP-aware message brokers (such as HornetQ) want their destinations prefixed in a manner different from "/queue/" or "/topic/". HornetQ, for example, wants it to be "jms.queue." or "jms.topic.".
> To address this, I've made some changes to StompHelper, adding the following URI parameters:
> * wireFormat.queuePrefix - defaults to "/queue/"
> * wireFormat.topicPrefix - defaults to "/topic/"
> * wireFormat.tempQueuePrefix - defaults to "/temp-queue/"
> * wireFormat.tempTopicPrefix - defaults to "/temp-topic/"
> My patch, however, fails to utilize the framework laid out by the StompWireformatProperties class, as the current code structure makes it very hard. Regardless, I've tested it with the SimpleProducer example (make sure you provide guest/guest as auth params if you're running a vanilla HornetQ) and it seems to work fine.
> The patch is against the activemq-cpp-3.4.1 tag as trunk wouldn't compile; some formatting issues may be present as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (AMQCPP-386) Run-time Setting of Destination Prefix

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQCPP-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish reassigned AMQCPP-386:
-----------------------------------

    Assignee: Timothy Bish
    
> Run-time Setting of Destination Prefix
> --------------------------------------
>
>                 Key: AMQCPP-386
>                 URL: https://issues.apache.org/jira/browse/AMQCPP-386
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>          Components: Stomp
>    Affects Versions: 3.3.0, 3.4.0, 3.4.1
>         Environment: All
>            Reporter: Mark Rappoport
>            Assignee: Timothy Bish
>            Priority: Minor
>              Labels: patch
>             Fix For: 3.5.0
>
>         Attachments: stomp-prefixes.patch
>
>
> Some STOMP-aware message brokers (such as HornetQ) want their destinations prefixed in a manner different from "/queue/" or "/topic/". HornetQ, for example, wants it to be "jms.queue." or "jms.topic.".
> To address this, I've made some changes to StompHelper, adding the following URI parameters:
> * wireFormat.queuePrefix - defaults to "/queue/"
> * wireFormat.topicPrefix - defaults to "/topic/"
> * wireFormat.tempQueuePrefix - defaults to "/temp-queue/"
> * wireFormat.tempTopicPrefix - defaults to "/temp-topic/"
> My patch, however, fails to utilize the framework laid out by the StompWireformatProperties class, as the current code structure makes it very hard. Regardless, I've tested it with the SimpleProducer example (make sure you provide guest/guest as auth params if you're running a vanilla HornetQ) and it seems to work fine.
> The patch is against the activemq-cpp-3.4.1 tag as trunk wouldn't compile; some formatting issues may be present as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AMQCPP-386) Run-time Setting of Destination Prefix

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AMQCPP-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489797#comment-13489797 ] 

Timothy Bish commented on AMQCPP-386:
-------------------------------------

Coded up the necessary changes, need to add a couple tests to verify the uri options are set correctly and applied. 
                
> Run-time Setting of Destination Prefix
> --------------------------------------
>
>                 Key: AMQCPP-386
>                 URL: https://issues.apache.org/jira/browse/AMQCPP-386
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>          Components: Stomp
>    Affects Versions: 3.3.0, 3.4.0, 3.4.1
>         Environment: All
>            Reporter: Mark Rappoport
>            Assignee: Timothy Bish
>            Priority: Minor
>              Labels: patch
>             Fix For: 3.5.0
>
>         Attachments: stomp-prefixes.patch
>
>
> Some STOMP-aware message brokers (such as HornetQ) want their destinations prefixed in a manner different from "/queue/" or "/topic/". HornetQ, for example, wants it to be "jms.queue." or "jms.topic.".
> To address this, I've made some changes to StompHelper, adding the following URI parameters:
> * wireFormat.queuePrefix - defaults to "/queue/"
> * wireFormat.topicPrefix - defaults to "/topic/"
> * wireFormat.tempQueuePrefix - defaults to "/temp-queue/"
> * wireFormat.tempTopicPrefix - defaults to "/temp-topic/"
> My patch, however, fails to utilize the framework laid out by the StompWireformatProperties class, as the current code structure makes it very hard. Regardless, I've tested it with the SimpleProducer example (make sure you provide guest/guest as auth params if you're running a vanilla HornetQ) and it seems to work fine.
> The patch is against the activemq-cpp-3.4.1 tag as trunk wouldn't compile; some formatting issues may be present as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Work started] (AMQCPP-386) Run-time Setting of Destination Prefix

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQCPP-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on AMQCPP-386 started by Timothy Bish.

> Run-time Setting of Destination Prefix
> --------------------------------------
>
>                 Key: AMQCPP-386
>                 URL: https://issues.apache.org/jira/browse/AMQCPP-386
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>          Components: Stomp
>    Affects Versions: 3.3.0, 3.4.0, 3.4.1
>         Environment: All
>            Reporter: Mark Rappoport
>            Assignee: Timothy Bish
>            Priority: Minor
>              Labels: patch
>             Fix For: 3.5.0
>
>         Attachments: stomp-prefixes.patch
>
>
> Some STOMP-aware message brokers (such as HornetQ) want their destinations prefixed in a manner different from "/queue/" or "/topic/". HornetQ, for example, wants it to be "jms.queue." or "jms.topic.".
> To address this, I've made some changes to StompHelper, adding the following URI parameters:
> * wireFormat.queuePrefix - defaults to "/queue/"
> * wireFormat.topicPrefix - defaults to "/topic/"
> * wireFormat.tempQueuePrefix - defaults to "/temp-queue/"
> * wireFormat.tempTopicPrefix - defaults to "/temp-topic/"
> My patch, however, fails to utilize the framework laid out by the StompWireformatProperties class, as the current code structure makes it very hard. Regardless, I've tested it with the SimpleProducer example (make sure you provide guest/guest as auth params if you're running a vanilla HornetQ) and it seems to work fine.
> The patch is against the activemq-cpp-3.4.1 tag as trunk wouldn't compile; some formatting issues may be present as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira