You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2011/03/09 19:58:59 UTC
[jira] Created: (HADOOP-7175) Add isEnabled() to Trash
Add isEnabled() to Trash
------------------------
Key: HADOOP-7175
URL: https://issues.apache.org/jira/browse/HADOOP-7175
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 0.22.0
Reporter: Daryn Sharp
Fix For: 0.22.0
The moveToTrash method returns false in a number of cases. It's not possible to discern if false means an error occurred. In particular, it's not possible to know if the trash is disabled vs. an error occurred.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7175) Add isEnabled() to Trash
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7175:
--------------------------------
Attachment: HADOOP-7175-2.patch
Remove tab.
> Add isEnabled() to Trash
> ------------------------
>
> Key: HADOOP-7175
> URL: https://issues.apache.org/jira/browse/HADOOP-7175
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7175-2.patch, HADOOP-7175.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The moveToTrash method returns false in a number of cases. It's not possible to discern if false means an error occurred. In particular, it's not possible to know if the trash is disabled vs. an error occurred.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7175) Add isEnabled() to Trash
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7175:
--------------------------------
Attachment: HADOOP-7175.patch
Adds isEnabled() method and corresponding tests.
> Add isEnabled() to Trash
> ------------------------
>
> Key: HADOOP-7175
> URL: https://issues.apache.org/jira/browse/HADOOP-7175
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Fix For: 0.22.0
>
> Attachments: HADOOP-7175.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The moveToTrash method returns false in a number of cases. It's not possible to discern if false means an error occurred. In particular, it's not possible to know if the trash is disabled vs. an error occurred.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7175) Add isEnabled() to Trash
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006872#comment-13006872 ]
Hudson commented on HADOOP-7175:
--------------------------------
Integrated in Hadoop-Common-trunk #631 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/631/])
HADOOP-7175. Add isEnabled() to Trash. Contributed by Daryn Sharp
> Add isEnabled() to Trash
> ------------------------
>
> Key: HADOOP-7175
> URL: https://issues.apache.org/jira/browse/HADOOP-7175
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7175-2.patch, HADOOP-7175.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The moveToTrash method returns false in a number of cases. It's not possible to discern if false means an error occurred. In particular, it's not possible to know if the trash is disabled vs. an error occurred.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7175) Add isEnabled() to Trash
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7175:
-------------------------------------------
Fix Version/s: (was: 0.22.0)
Affects Version/s: (was: 0.22.0)
Status: Open (was: Patch Available)
> Add isEnabled() to Trash
> ------------------------
>
> Key: HADOOP-7175
> URL: https://issues.apache.org/jira/browse/HADOOP-7175
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Daryn Sharp
> Attachments: HADOOP-7175.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The moveToTrash method returns false in a number of cases. It's not possible to discern if false means an error occurred. In particular, it's not possible to know if the trash is disabled vs. an error occurred.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7175) Add isEnabled() to Trash
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7175:
--------------------------------
Status: Patch Available (was: Open)
> Add isEnabled() to Trash
> ------------------------
>
> Key: HADOOP-7175
> URL: https://issues.apache.org/jira/browse/HADOOP-7175
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Fix For: 0.22.0
>
> Attachments: HADOOP-7175.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The moveToTrash method returns false in a number of cases. It's not possible to discern if false means an error occurred. In particular, it's not possible to know if the trash is disabled vs. an error occurred.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7175) Add isEnabled() to Trash
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005801#comment-13005801 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-7175:
------------------------------------------------
Hi Daryn, there is a tab in the new isEnabled() method. We don't use tabs in Hadoop. Could you remove it? Other then that the patch looks good.
> Add isEnabled() to Trash
> ------------------------
>
> Key: HADOOP-7175
> URL: https://issues.apache.org/jira/browse/HADOOP-7175
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7175.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The moveToTrash method returns false in a number of cases. It's not possible to discern if false means an error occurred. In particular, it's not possible to know if the trash is disabled vs. an error occurred.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7175) Add isEnabled() to Trash
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7175:
-------------------------------------------
Fix Version/s: 0.23.0
Assignee: Daryn Sharp
Status: Patch Available (was: Open)
> Add isEnabled() to Trash
> ------------------------
>
> Key: HADOOP-7175
> URL: https://issues.apache.org/jira/browse/HADOOP-7175
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7175.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The moveToTrash method returns false in a number of cases. It's not possible to discern if false means an error occurred. In particular, it's not possible to know if the trash is disabled vs. an error occurred.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HADOOP-7175) Add isEnabled() to Trash
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7175:
-------------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I have committed this. Thanks, Daryn!
(Hudson seems not able to pick up COMMON patches automatically. I have manually started the hudson build.)
> Add isEnabled() to Trash
> ------------------------
>
> Key: HADOOP-7175
> URL: https://issues.apache.org/jira/browse/HADOOP-7175
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7175-2.patch, HADOOP-7175.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The moveToTrash method returns false in a number of cases. It's not possible to discern if false means an error occurred. In particular, it's not possible to know if the trash is disabled vs. an error occurred.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7175) Add isEnabled() to Trash
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006558#comment-13006558 ]
Daryn Sharp commented on HADOOP-7175:
-------------------------------------
test-contrib:
test:
compile:
test:
python.pathcheck:
[echo] 'python.home' is not defined. Please pass -Dpython.home=<Path to Python> to Ant on the command-line.
checkAndRunTests:
BUILD SUCCESSFUL
> Add isEnabled() to Trash
> ------------------------
>
> Key: HADOOP-7175
> URL: https://issues.apache.org/jira/browse/HADOOP-7175
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7175-2.patch, HADOOP-7175.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The moveToTrash method returns false in a number of cases. It's not possible to discern if false means an error occurred. In particular, it's not possible to know if the trash is disabled vs. an error occurred.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7175) Add isEnabled() to Trash
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006681#comment-13006681 ]
Hadoop QA commented on HADOOP-7175:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12473427/HADOOP-7175-2.patch
against trunk revision 1080817.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/309//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/309//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/309//console
This message is automatically generated.
> Add isEnabled() to Trash
> ------------------------
>
> Key: HADOOP-7175
> URL: https://issues.apache.org/jira/browse/HADOOP-7175
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7175-2.patch, HADOOP-7175.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The moveToTrash method returns false in a number of cases. It's not possible to discern if false means an error occurred. In particular, it's not possible to know if the trash is disabled vs. an error occurred.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7175) Add isEnabled() to Trash
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006703#comment-13006703 ]
Hudson commented on HADOOP-7175:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #528 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/528/])
HADOOP-7175. Add isEnabled() to Trash. Contributed by Daryn Sharp
> Add isEnabled() to Trash
> ------------------------
>
> Key: HADOOP-7175
> URL: https://issues.apache.org/jira/browse/HADOOP-7175
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7175-2.patch, HADOOP-7175.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The moveToTrash method returns false in a number of cases. It's not possible to discern if false means an error occurred. In particular, it's not possible to know if the trash is disabled vs. an error occurred.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira