You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Fine0830 (via GitHub)" <gi...@apache.org> on 2023/07/12 13:03:46 UTC
[GitHub] [skywalking] Fine0830 opened a new pull request, #11083: Sync ui
Fine0830 opened a new pull request, #11083:
URL: https://github.com/apache/skywalking/pull/11083
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
Implement menus i18n and add a doc to explain how to manage i18n.
Signed-off-by: Qiuxia Fan <qi...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #11083: Sync ui
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #11083:
URL: https://github.com/apache/skywalking/pull/11083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11083: Sync ui
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #11083:
URL: https://github.com/apache/skywalking/pull/11083#discussion_r1261282921
##########
docs/en/guides/i18n.md:
##########
@@ -0,0 +1,10 @@
+# Guide
+> This section explains how to manage translations for internationalization of menu items.
+
+SkyWalking UI's internationalization translations are in the [src/locales/lang](https://github.com/apache/skywalking-booster-ui/tree/main/src/locales/lang). And the translations for the menu items are in [src/locales/lang/menus](https://github.com/apache/skywalking-booster-ui/tree/main/src/locales/lang/menus), including `label` and `description`. The translation key of `label` which is the value of `i18nKey` is from `oap-server/server-starter/src/main/resources/ui-initialized-templates/menu.yaml`. The translation key of `description` consists of the `i18nKey` value and `_desc`. The `description` contents will be displayed on the Marketplace page. For example,
Review Comment:
```suggestion
SkyWalking UI's internationalization translations are in the [src/locales/lang](https://github.com/apache/skywalking-booster-ui/tree/main/src/locales/lang).
The translations include `menu name` and `description`. The translation key of `menu name` is the value of `i18nKey` from [menu definition file](../../../oap-server/server-starter/src/main/resources/ui-initialized-templates/menu.yaml). The translation key of `description` consists of the `i18nKey` value and `_desc` suffix. The `description` contents will be displayed on the Marketplace page.
The following is a typical `menu name` and `description` for i18nKey=`general_service`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11083: Sync ui
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #11083:
URL: https://github.com/apache/skywalking/pull/11083#discussion_r1261208230
##########
docs/en/guides/i18n.md:
##########
@@ -0,0 +1,10 @@
+# Guide
+> This section explains how to manage translations for internationalization of menu items.
+
+SkyWalking UI's internationalization translations are in the `src/locales/lang`. And the translations for the menu items are in `src/locales/lang/menus`, including `label` and `description`. The translation key of `label` which is the value of `i18nKey` is from [ui-initialized-templates/menu.yaml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/ui-initialized-templates/menu.yaml). The translation key of `description` consists of the `i18nKey` value and `_desc`. The `description` contents will be displayed in the Marketplace page. For example,
Review Comment:
```suggestion
SkyWalking UI's internationalization translations are in the `src/locales/lang`. And the translations for the menu items are in `src/locales/lang/menus`, including `label` and `description`. The translation key of `label` which is the value of `i18nKey` is from [ui-initialized-templates/menu.yaml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/ui-initialized-templates/menu.yaml). The translation key of `description` consists of the `i18nKey` value and `_desc`. The `description` contents will be displayed on the Marketplace page. For example,
```
The link should be a relative path, then, our doc build could generate a link with the current release or latest build automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org