You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/29 09:26:23 UTC

[GitHub] [arrow] cyb70289 commented on a diff in pull request #13437: ARROW-16872: [C++] Fix csv parser edge case

cyb70289 commented on code in PR #13437:
URL: https://github.com/apache/arrow/pull/13437#discussion_r909406531


##########
cpp/src/arrow/csv/parser.cc:
##########
@@ -296,6 +297,9 @@ class BlockParserImpl {
     if (UseBulkFilter) {
       const char* bulk_end = RunBulkFilter(parsed_writer, data, data_end, bulk_filter);
       if (ARROW_PREDICT_FALSE(bulk_end == nullptr)) {
+        if (is_final) {
+          final_offset = static_cast<int32_t>(data_end - data);

Review Comment:
   `data` is used in line https://github.com/apache/arrow/blob/master/cpp/src/arrow/csv/parser.cc#L387 if there are fewer rows than expected. Didn't read deep`HandleInvalidRow` code, will updating `data` cause problem?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org