You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "Roiocam (via GitHub)" <gi...@apache.org> on 2024/09/11 11:49:28 UTC
[PR] add unit test protect ExtractEntityId can be shared safely [pekko]
Roiocam opened a new pull request, #1475:
URL: https://github.com/apache/pekko/pull/1475
Related with #1463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] add unit test protect ExtractEntityId can be shared safely [pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #1475:
URL: https://github.com/apache/pekko/pull/1475#issuecomment-2343642643
> Can we add the unit test independently of the main source changes?
Cherry-pick commit is to verify the effective of the unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] add unit test protect ExtractEntityId can be shared safely [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1475:
URL: https://github.com/apache/pekko/pull/1475#discussion_r1754564980
##########
cluster-sharding/src/test/scala/org/apache/pekko/cluster/sharding/ShardRegionSpec.scala:
##########
@@ -18,12 +18,17 @@ import java.io.File
import com.typesafe.config.ConfigFactory
import org.apache.commons.io.FileUtils
import org.apache.pekko
+import org.apache.pekko.Done
Review Comment:
can you remove the org.apache prefix for the new imports?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] add unit test protect ExtractEntityId can be shared safely [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1475:
URL: https://github.com/apache/pekko/pull/1475#issuecomment-2343503411
Can we add the unit test independently of the main source changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] add unit test protect ExtractEntityId can be shared safely [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1475:
URL: https://github.com/apache/pekko/pull/1475#discussion_r1754303241
##########
cluster-sharding/src/test/scala/org/apache/pekko/cluster/sharding/ShardRegionSpec.scala:
##########
@@ -183,4 +215,43 @@ class ShardRegionSpec extends PekkoSpec(ShardRegionSpec.config) with WithLogCapt
}
}
+ "ExtractEntityId" must {
+ "can be safely share to multiple shards" in {
Review Comment:
"be safely able to share multiple shards" reads better to me
When the test runs it prints:
ExtractEntityId must can ... -- this is bad grammar in English
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] add unit test protect ExtractEntityId can be shared safely [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #1475:
URL: https://github.com/apache/pekko/pull/1475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org