You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2023/11/18 02:16:57 UTC

[PR] [FLINK-33597][table] Cleanup usage of deprecated TableTestBase#addFunction [flink]

snuyanzin opened a new pull request, #23748:
URL: https://github.com/apache/flink/pull/23748

   
   ## What is the purpose of the change
   
   Removes the usage of the deprecated method `TableTestBase#addFunction`
   
   
   
   ## Brief change log
   
   Replace the usage of  `TableTestBase#addFunction` with  `TableTestBase#addFunction#addTemporarySystemFunction`
   
   
   ## Verifying this change
   
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: ( no)
     - The runtime per-record code paths (performance sensitive): ( no )
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
     - The S3 file system connector: ( no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33597][table] Cleanup usage of deprecated TableTestBase#addFunction [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23748:
URL: https://github.com/apache/flink/pull/23748#issuecomment-1817330805

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b5bca01a28f370b0048200eb8204b51279a67b1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6b5bca01a28f370b0048200eb8204b51279a67b1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6b5bca01a28f370b0048200eb8204b51279a67b1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33591][table] Cleanup usage of deprecated TableTestBase#addFunction [flink]

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #23748:
URL: https://github.com/apache/flink/pull/23748#issuecomment-1822921432

   thanks for taking a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33591][table] Cleanup usage of deprecated TableTestBase#addFunction [flink]

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin closed pull request #23748: [FLINK-33591][table] Cleanup usage of deprecated TableTestBase#addFunction
URL: https://github.com/apache/flink/pull/23748


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org