You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/24 03:26:41 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
gaoyunhaii opened a new pull request #16950:
URL: https://github.com/apache/flink/pull/16950
## What is the purpose of the change
This PR fixes that some tests use the default DateTimeBucketAssigner which partitions the data into buckets according to the hour, if the test are executed at the boundary of an hour, the data might be write into two buckets, but the tests will validate that there is only one bucket.
## Brief change log
- 4ecced5f26139215ae8555cc358291c46e9c7bfb adds a default `UniqueBucketAssigner` and configure the bucket assigner explicitly.
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16950:
URL: https://github.com/apache/flink/pull/16950#issuecomment-904302769
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ecced5f26139215ae8555cc358291c46e9c7bfb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on a change in pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #16950:
URL: https://github.com/apache/flink/pull/16950#discussion_r695322819
##########
File path: flink-formats/flink-orc/pom.xml
##########
@@ -18,175 +18,183 @@ specific language governing permissions and limitations
under the License.
-->
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
-
- <modelVersion>4.0.0</modelVersion>
-
- <parent>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-formats</artifactId>
- <version>1.14-SNAPSHOT</version>
- <relativePath>..</relativePath>
- </parent>
-
- <artifactId>flink-orc_${scala.binary.version}</artifactId>
- <name>Flink : Formats : Orc</name>
-
- <packaging>jar</packaging>
-
- <dependencies>
-
- <!-- Core -->
-
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <scope>provided</scope>
- </dependency>
-
- <!-- Table ecosystem -->
-
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-table-runtime_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <scope>provided</scope>
- </dependency>
-
- <!-- ORC -->
-
- <dependency>
- <groupId>org.apache.orc</groupId>
- <artifactId>orc-core</artifactId>
- <version>${orc.version}</version>
- <exclusions>
- <!-- Exclude ORC's Hadoop dependency and pull in provided vanilla hadoop. -->
- <exclusion>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-common</artifactId>
- </exclusion>
- <exclusion>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-hdfs</artifactId>
- </exclusion>
- <exclusion>
- <groupId>javax.activation</groupId>
- <artifactId>javax.activation-api</artifactId>
- </exclusion>
- <exclusion>
- <groupId>javax.xml.bind</groupId>
- <artifactId>jaxb-api</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-lang3</artifactId>
- <scope>provided</scope>
- </dependency>
-
- <dependency>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-common</artifactId>
- <scope>provided</scope>
- </dependency>
-
- <dependency>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-hdfs</artifactId>
- <scope>provided</scope>
- </dependency>
-
- <!-- Tests -->
-
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-test-utils_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <scope>test</scope>
- </dependency>
-
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <scope>test</scope>
- <type>test-jar</type>
- </dependency>
-
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-statebackend-changelog</artifactId>
- <version>${project.version}</version>
- <scope>test</scope>
- </dependency>
-
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <scope>test</scope>
- </dependency>
-
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <scope>test</scope>
- <type>test-jar</type>
- </dependency>
-
- </dependencies>
-
- <profiles>
- <profile>
- <!-- This profile adds dependencies needed to execute the tests
- with Hadoop 3 -->
- <id>hadoop3-tests</id>
- <dependencies>
- <dependency>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-hdfs-client</artifactId>
- <version>${hadoop.version}</version>
- <scope>test</scope>
- </dependency>
- </dependencies>
- </profile>
- </profiles>
-
-
- <build>
- <plugins>
- <!-- skip dependency convergence due to Hadoop dependency -->
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-enforcer-plugin</artifactId>
- <executions>
- <execution>
- <id>dependency-convergence</id>
- <goals>
- <goal>enforce</goal>
- </goals>
- <configuration>
- <skip>true</skip>
- </configuration>
- </execution>
- </executions>
- </plugin>
-
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-jar-plugin</artifactId>
- <executions>
- <execution>
- <goals>
- <goal>test-jar</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
Review comment:
I think the most diff is from the format. Maybe we could avoid this. WDYT？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #16950:
URL: https://github.com/apache/flink/pull/16950#issuecomment-905246077
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16950:
URL: https://github.com/apache/flink/pull/16950#issuecomment-904302769
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22696",
"triggerID" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"triggerType" : "PUSH"
}, {
"hash" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ecced5f26139215ae8555cc358291c46e9c7bfb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22696)
* 288ae542bccde9a2cad06fcc88fea1c566e59d50 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16950:
URL: https://github.com/apache/flink/pull/16950#issuecomment-904302769
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22696",
"triggerID" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ecced5f26139215ae8555cc358291c46e9c7bfb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22696)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii closed pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
gaoyunhaii closed pull request #16950:
URL: https://github.com/apache/flink/pull/16950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on a change in pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #16950:
URL: https://github.com/apache/flink/pull/16950#discussion_r694617353
##########
File path: flink-connectors/flink-file-sink-common/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/bucketassigners/UniqueBucketAssigner.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.functions.sink.filesystem.bucketassigners;
+
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+import org.apache.flink.streaming.api.functions.sink.filesystem.BucketAssigner;
+
+/** A {@link BucketAssigner} that write all the files into the unique bucket. */
+public class UniqueBucketAssigner<T> implements BucketAssigner<T, String> {
Review comment:
Because this class is only used for testing, could you consider putting it in the test package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16950:
URL: https://github.com/apache/flink/pull/16950#issuecomment-904302769
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22696",
"triggerID" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"triggerType" : "PUSH"
}, {
"hash" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22764",
"triggerID" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"triggerType" : "PUSH"
}, {
"hash" : "d1cf5880f76840365ed88597b22a216688f8128d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22785",
"triggerID" : "d1cf5880f76840365ed88597b22a216688f8128d",
"triggerType" : "PUSH"
}, {
"hash" : "d1cf5880f76840365ed88597b22a216688f8128d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22797",
"triggerID" : "905246077",
"triggerType" : "MANUAL"
}, {
"hash" : "d1cf5880f76840365ed88597b22a216688f8128d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22785",
"triggerID" : "905246077",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d1cf5880f76840365ed88597b22a216688f8128d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22797) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22785)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16950:
URL: https://github.com/apache/flink/pull/16950#issuecomment-904302769
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22696",
"triggerID" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"triggerType" : "PUSH"
}, {
"hash" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22764",
"triggerID" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"triggerType" : "PUSH"
}, {
"hash" : "d1cf5880f76840365ed88597b22a216688f8128d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22785",
"triggerID" : "d1cf5880f76840365ed88597b22a216688f8128d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1cf5880f76840365ed88597b22a216688f8128d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22785)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16950:
URL: https://github.com/apache/flink/pull/16950#issuecomment-904302769
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22696",
"triggerID" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"triggerType" : "PUSH"
}, {
"hash" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22764",
"triggerID" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 288ae542bccde9a2cad06fcc88fea1c566e59d50 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22764)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16950:
URL: https://github.com/apache/flink/pull/16950#issuecomment-904302769
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22696",
"triggerID" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"triggerType" : "PUSH"
}, {
"hash" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22764",
"triggerID" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"triggerType" : "PUSH"
}, {
"hash" : "d1cf5880f76840365ed88597b22a216688f8128d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22785",
"triggerID" : "d1cf5880f76840365ed88597b22a216688f8128d",
"triggerType" : "PUSH"
}, {
"hash" : "d1cf5880f76840365ed88597b22a216688f8128d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22797",
"triggerID" : "905246077",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d1cf5880f76840365ed88597b22a216688f8128d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22785) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22797)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16950:
URL: https://github.com/apache/flink/pull/16950#issuecomment-904302769
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22696",
"triggerID" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"triggerType" : "PUSH"
}, {
"hash" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22764",
"triggerID" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"triggerType" : "PUSH"
}, {
"hash" : "d1cf5880f76840365ed88597b22a216688f8128d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d1cf5880f76840365ed88597b22a216688f8128d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 288ae542bccde9a2cad06fcc88fea1c566e59d50 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22764)
* d1cf5880f76840365ed88597b22a216688f8128d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16950:
URL: https://github.com/apache/flink/pull/16950#issuecomment-904302769
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22696",
"triggerID" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"triggerType" : "PUSH"
}, {
"hash" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22764",
"triggerID" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"triggerType" : "PUSH"
}, {
"hash" : "d1cf5880f76840365ed88597b22a216688f8128d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22785",
"triggerID" : "d1cf5880f76840365ed88597b22a216688f8128d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 288ae542bccde9a2cad06fcc88fea1c566e59d50 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22764)
* d1cf5880f76840365ed88597b22a216688f8128d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22785)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on a change in pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
guoweiM commented on a change in pull request #16950:
URL: https://github.com/apache/flink/pull/16950#discussion_r695328018
##########
File path: flink-connectors/flink-file-sink-common/src/test/java/org/apache/flink/streaming/api/functions/sink/filesystem/bucketassigners/UniqueBucketAssigner.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.functions.sink.filesystem.bucketassigners;
+
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+import org.apache.flink.streaming.api.functions.sink.filesystem.BucketAssigner;
+
+/** A {@link BucketAssigner} that write all the files into the unique bucket. */
Review comment:
write ---> assigns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16950:
URL: https://github.com/apache/flink/pull/16950#issuecomment-904302769
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22696",
"triggerID" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"triggerType" : "PUSH"
}, {
"hash" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22764",
"triggerID" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ecced5f26139215ae8555cc358291c46e9c7bfb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22696)
* 288ae542bccde9a2cad06fcc88fea1c566e59d50 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22764)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #16950:
URL: https://github.com/apache/flink/pull/16950#issuecomment-905137143
Very thanks @guoweiM for the review! I updated the PR according to the comments~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16950:
URL: https://github.com/apache/flink/pull/16950#issuecomment-904294361
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4ecced5f26139215ae8555cc358291c46e9c7bfb (Tue Aug 24 03:30:23 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16950:
URL: https://github.com/apache/flink/pull/16950#issuecomment-904302769
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22696",
"triggerID" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ecced5f26139215ae8555cc358291c46e9c7bfb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22696)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16950:
URL: https://github.com/apache/flink/pull/16950#issuecomment-904302769
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22696",
"triggerID" : "4ecced5f26139215ae8555cc358291c46e9c7bfb",
"triggerType" : "PUSH"
}, {
"hash" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22764",
"triggerID" : "288ae542bccde9a2cad06fcc88fea1c566e59d50",
"triggerType" : "PUSH"
}, {
"hash" : "d1cf5880f76840365ed88597b22a216688f8128d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22785",
"triggerID" : "d1cf5880f76840365ed88597b22a216688f8128d",
"triggerType" : "PUSH"
}, {
"hash" : "d1cf5880f76840365ed88597b22a216688f8128d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22797",
"triggerID" : "905246077",
"triggerType" : "MANUAL"
}, {
"hash" : "d1cf5880f76840365ed88597b22a216688f8128d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22785",
"triggerID" : "905246077",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d1cf5880f76840365ed88597b22a216688f8128d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22797) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22785)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #16950:
URL: https://github.com/apache/flink/pull/16950#discussion_r695015797
##########
File path: flink-connectors/flink-file-sink-common/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/bucketassigners/UniqueBucketAssigner.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.api.functions.sink.filesystem.bucketassigners;
+
+import org.apache.flink.core.io.SimpleVersionedSerializer;
+import org.apache.flink.streaming.api.functions.sink.filesystem.BucketAssigner;
+
+/** A {@link BucketAssigner} that write all the files into the unique bucket. */
+public class UniqueBucketAssigner<T> implements BucketAssigner<T, String> {
Review comment:
Yes, it would be better to be in a test package, I update the PR according to this method~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #16950:
URL: https://github.com/apache/flink/pull/16950#discussion_r695350369
##########
File path: flink-formats/flink-orc/pom.xml
##########
@@ -18,175 +18,183 @@ specific language governing permissions and limitations
under the License.
-->
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
-
- <modelVersion>4.0.0</modelVersion>
-
- <parent>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-formats</artifactId>
- <version>1.14-SNAPSHOT</version>
- <relativePath>..</relativePath>
- </parent>
-
- <artifactId>flink-orc_${scala.binary.version}</artifactId>
- <name>Flink : Formats : Orc</name>
-
- <packaging>jar</packaging>
-
- <dependencies>
-
- <!-- Core -->
-
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <scope>provided</scope>
- </dependency>
-
- <!-- Table ecosystem -->
-
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-table-runtime_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <scope>provided</scope>
- </dependency>
-
- <!-- ORC -->
-
- <dependency>
- <groupId>org.apache.orc</groupId>
- <artifactId>orc-core</artifactId>
- <version>${orc.version}</version>
- <exclusions>
- <!-- Exclude ORC's Hadoop dependency and pull in provided vanilla hadoop. -->
- <exclusion>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-common</artifactId>
- </exclusion>
- <exclusion>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-hdfs</artifactId>
- </exclusion>
- <exclusion>
- <groupId>javax.activation</groupId>
- <artifactId>javax.activation-api</artifactId>
- </exclusion>
- <exclusion>
- <groupId>javax.xml.bind</groupId>
- <artifactId>jaxb-api</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-lang3</artifactId>
- <scope>provided</scope>
- </dependency>
-
- <dependency>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-common</artifactId>
- <scope>provided</scope>
- </dependency>
-
- <dependency>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-hdfs</artifactId>
- <scope>provided</scope>
- </dependency>
-
- <!-- Tests -->
-
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-test-utils_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <scope>test</scope>
- </dependency>
-
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <scope>test</scope>
- <type>test-jar</type>
- </dependency>
-
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-statebackend-changelog</artifactId>
- <version>${project.version}</version>
- <scope>test</scope>
- </dependency>
-
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <scope>test</scope>
- </dependency>
-
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
- <version>${project.version}</version>
- <scope>test</scope>
- <type>test-jar</type>
- </dependency>
-
- </dependencies>
-
- <profiles>
- <profile>
- <!-- This profile adds dependencies needed to execute the tests
- with Hadoop 3 -->
- <id>hadoop3-tests</id>
- <dependencies>
- <dependency>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-hdfs-client</artifactId>
- <version>${hadoop.version}</version>
- <scope>test</scope>
- </dependency>
- </dependencies>
- </profile>
- </profiles>
-
-
- <build>
- <plugins>
- <!-- skip dependency convergence due to Hadoop dependency -->
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-enforcer-plugin</artifactId>
- <executions>
- <execution>
- <id>dependency-convergence</id>
- <goals>
- <goal>enforce</goal>
- </goals>
- <configuration>
- <skip>true</skip>
- </configuration>
- </execution>
- </executions>
- </plugin>
-
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-jar-plugin</artifactId>
- <executions>
- <execution>
- <goals>
- <goal>test-jar</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
Review comment:
I also think we should avoid this, sorry for changing the format...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #16950: [FLINK-22710][formats] Explicitly set the bucket assigner to avoid writing into two buckets in the tests
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #16950:
URL: https://github.com/apache/flink/pull/16950#issuecomment-905414830
Very thanks @guoweiM for the review! I'll merge the code~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org