You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/07 22:56:12 UTC
[GitHub] [solr] HoustonPutman opened a new pull request #734: SOLR-16086: Fixes for doTestIndexFetchOnLeaderRestart
HoustonPutman opened a new pull request #734:
URL: https://github.com/apache/solr/pull/734
https://issues.apache.org/jira/browse/SOLR-16086
WIP still looking around here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #734: SOLR-16086: Fixes for doTestIndexFetchOnLeaderRestart
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #734:
URL: https://github.com/apache/solr/pull/734#discussion_r825166570
##########
File path: solr/core/src/java/org/apache/solr/client/solrj/embedded/JettySolrRunner.java
##########
@@ -697,12 +694,6 @@ public synchronized void stop() throws Exception {
timeout.waitFor("Timeout waiting for reserved executor to stop.", rte::isStopped);
}
- // we want to shutdown outside of jetty cutting us off
- SolrDispatchFilter sdf = getSolrDispatchFilter();
- if (sdf != null) {
- ExecutorUtil.shutdownAndAwaitTermination(getJettyShutDownThreadPool());
Review comment:
This looks dubious (the code, not the removal) but I'm unclear if that's the same bug you're addressing here or a separate problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on a change in pull request #734: SOLR-16086: Fixes for doTestIndexFetchOnLeaderRestart
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #734:
URL: https://github.com/apache/solr/pull/734#discussion_r825173836
##########
File path: solr/core/src/java/org/apache/solr/client/solrj/embedded/JettySolrRunner.java
##########
@@ -697,12 +694,6 @@ public synchronized void stop() throws Exception {
timeout.waitFor("Timeout waiting for reserved executor to stop.", rte::isStopped);
}
- // we want to shutdown outside of jetty cutting us off
- SolrDispatchFilter sdf = getSolrDispatchFilter();
- if (sdf != null) {
- ExecutorUtil.shutdownAndAwaitTermination(getJettyShutDownThreadPool());
Review comment:
It's unrelated, this executor isn't used for anything (at least that I can tell)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org