You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by GitBox <gi...@apache.org> on 2021/03/17 04:07:38 UTC

[GitHub] [tika] Subhajitdas298 opened a new pull request #417: TIKA-3327 Simple server metrics monitoring

Subhajitdas298 opened a new pull request #417:
URL: https://github.com/apache/tika/pull/417


   For TIKA-3327,
   
   Added very simple MBean for exposing ServerStatus (over an abstraction to enable readonly).
   
   This is **activated when status is enabled** using command line.
   
   This can be used along side Prometheus JMX exporter (or other tool like Jconsole).
   
   Sample Prometheus JMX exporter usage:
   
   Standalone: _java -javaagent:./jmx_prometheus_javaagent-0.15.0.jar=8080:../config/jmx-config.yaml -jar .\tika-server-1.26-SNAPSHOT.jar -status_
   
   Parent-Child mode: _java -cp .\tika-server-1.26-SNAPSHOT.jar org.apache.tika.server.TikaServerCli -status -spawnChild -Jjavaagent:./jmx_prometheus_javaagent-0.15.0.jar=8080:../config/jmx-config.yaml_
   
   Note: MBean works irrespective of java execution mode (-jar or -cp ..Cli). And JMX exporter by default exposes a lot of JVM metrices.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tika] tballison merged pull request #417: TIKA-3327 Simple server metrics monitoring

Posted by GitBox <gi...@apache.org>.
tballison merged pull request #417:
URL: https://github.com/apache/tika/pull/417


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tika] lewismc commented on a change in pull request #417: TIKA-3327 Simple server metrics monitoring

Posted by GitBox <gi...@apache.org>.
lewismc commented on a change in pull request #417:
URL: https://github.com/apache/tika/pull/417#discussion_r769277762



##########
File path: tika-server/src/main/java/org/apache/tika/server/mbean/ServerStatusExporter.java
##########
@@ -0,0 +1,66 @@
+package org.apache.tika.server.mbean;

Review comment:
       Missing license header?

##########
File path: tika-server/src/main/java/org/apache/tika/server/mbean/ServerStatusExporterMBean.java
##########
@@ -0,0 +1,44 @@
+package org.apache.tika.server.mbean;

Review comment:
       Missing license header?

##########
File path: tika-server/src/main/java/org/apache/tika/server/TikaServerCli.java
##########
@@ -70,6 +72,8 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import javax.management.*;

Review comment:
       I would remove wildcard imports...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org