[GitHub] [skywalking-terraform] rabajaj0509 commented on a diff in pull request #12: Implement env variables support for WebUI systemd unit file

["rabajaj0509 (via GitHub)" <gi...@apache.org>]

rabajaj0509 commented on code in PR #12:
URL: https://github.com/apache/skywalking-terraform/pull/12#discussion_r1278760222


##########
ansible/roles/skywalking/vars/main.yml:
##########
@@ -15,3 +15,10 @@
 
 ---
 skywalking_version: "9.5.0"
+sw_server_port: "8080"
+sw_oap_server_port: 12800
+
+env_vars:
+  SW_SERVER_PORT: "{{ sw_ui_server_port }}"
+  SW_OAP_ADDRESS: "{{ hostvars[groups['skywalking-oap'][0]].ansible_host }}:{{ sw_oap_server_port }}"

Review Comment:
   Is it ok to address the cluster mode in the next PR? It might require changes in the way we handle ansible inventory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org