You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2018/04/09 05:43:04 UTC
[jira] [Commented] (HBASE-20199) Add test to prevent further
permission regression around table flush and snapshot
[ https://issues.apache.org/jira/browse/HBASE-20199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430047#comment-16430047 ]
Hudson commented on HBASE-20199:
--------------------------------
Results for branch HBASE-19064
[build #90 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/90/]: (x) *{color:red}-1 overall{color}*
----
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/90//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/90//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/90//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add test to prevent further permission regression around table flush and snapshot
> ---------------------------------------------------------------------------------
>
> Key: HBASE-20199
> URL: https://issues.apache.org/jira/browse/HBASE-20199
> Project: HBase
> Issue Type: Task
> Components: test
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-20199.001.branch-2.0.patch, HBASE-20199.002.branch-2.0.patch, HBASE-20199.003.branch-2.0.patch
>
>
> {quote}
> There is already a test for that in TestAccessController- [https://github.com/apache/hbase/blob/master/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java#L809], - however, those tests are hacked to not run the operations but the AC hooks directly. for eg. instead of triggering flush, it just runs ACCESS_CONTROLLER.preTableFlush(). It's not possible/good to change just a few tests there given that will break the overall design and make things harder to maintain.
> The new test should go in TestAdminOnlyOperations (and the test class name should probably be changed to TestRpcAccessChecks).
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)