You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/06/15 02:56:25 UTC
[GitHub] [incubator-brpc] TousakaRin opened a new pull request #1139: For https naming service, use 443 as default port
TousakaRin opened a new pull request #1139:
URL: https://github.com/apache/incubator-brpc/pull/1139
当naming service使用https时，使用443作为默认端口。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] jamesge commented on a change in pull request #1139: For https naming service, use 443 as default port
Posted by GitBox <gi...@apache.org>.
jamesge commented on a change in pull request #1139:
URL: https://github.com/apache/incubator-brpc/pull/1139#discussion_r439941725
##########
File path: src/brpc/details/naming_service_thread.cpp
##########
@@ -38,6 +46,15 @@ struct NSKey {
const std::string& service_in,
const ChannelSignature& sig)
: protocol(prot_in), service_name(service_in), channel_signature(sig) {
+ if (CompareStringPieceWithoutCase(protocol, "https") &&
Review comment:
类似的代码应该加在policy/domain_naming_service.cpp里？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] jamesge merged pull request #1139: For https naming service, use 443 as default port
Posted by GitBox <gi...@apache.org>.
jamesge merged pull request #1139:
URL: https://github.com/apache/incubator-brpc/pull/1139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] jamesge commented on a change in pull request #1139: For https naming service, use 443 as default port
Posted by GitBox <gi...@apache.org>.
jamesge commented on a change in pull request #1139:
URL: https://github.com/apache/incubator-brpc/pull/1139#discussion_r459977354
##########
File path: src/brpc/details/naming_service_thread.cpp
##########
@@ -38,6 +46,15 @@ struct NSKey {
const std::string& service_in,
const ChannelSignature& sig)
: protocol(prot_in), service_name(service_in), channel_signature(sig) {
+ if (CompareStringPieceWithoutCase(protocol, "https") &&
Review comment:
看上去是可以的，DomainNamingService的ctor加个参数就行了。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org