[GitHub] [arrow] bkietz commented on pull request #35565: GH-35498: [C++] Relax EnsureAlignment check in Acero from requiring 64-byte aligned buffers to requiring value-aligned buffers

["bkietz (via GitHub)" <gi...@apache.org>]

bkietz commented on PR #35565:
URL: https://github.com/apache/arrow/pull/35565#issuecomment-1554584810

   [> So how do we feel about:](https://github.com/apache/arrow/pull/35565#issuecomment-1552401874)
   
   This seems fine to me, with the caveat that always emitting a warning is inflexible for users who definitely want to avoid unaligned access. Perhaps they're building for a platform we're not aware of where unaligned access has more disastrous consequences than we've seen, or maybe they're just running with a sanitizer which detects unaligned access and emits an error even if the platform would allow the access. Therefore, I think that for the time being there should be a build option or at least an environment variable which such a user could set to ensure alignment.
   
   Also I think both the build option and the warning should be tagged with the number of an issue tracking (or, later: a link to documentation on) producers of unaligned data and how to mitigate that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org