[GitHub] [airflow] jmcarp commented on issue #5259: [AIRFLOW-4089] Use shared `Resources` instances by default.

[GitBox <gi...@apache.org>]

jmcarp commented on issue #5259: [AIRFLOW-4089] Use shared `Resources` instances by default.
URL: https://github.com/apache/airflow/pull/5259#issuecomment-498105179
 
 
   Thanks @potiuk. I reimplemented both `Resource` and `Resources` as `namedtuple`s both to clean up the code and to make sure both are immutable. I also see that the gpu and disk limits are undocumented and not referred to elsewhere in the code, so I propose that we drop them--I don't even think cgroups support limits on disk space or gpu shares, and they definitely aren't supported in cgroupspy. Last, it looks like the kubernetes system implements its own independent `Resources` class at https://github.com/apache/airflow/blob/master/airflow/kubernetes/pod.py#L19-L38 and doesn't overlap with these classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services