[GitHub] [incubator-seatunnel] leo65535 edited a comment on pull request #906: [SeaTunnel #904] [config] improve the config parse logic

[GitBox <gi...@apache.org>]

leo65535 edited a comment on pull request #906:
URL: https://github.com/apache/incubator-seatunnel/pull/906#issuecomment-1003655792


   hi @simon824 @garyelephant thanks for your review.
   
   ### Questions
   
   > can you briefly explain how to implement the config parsing logic to keep the order as in config file
   
   I move all your sort logic to `SeaTunnelConfigParser` which using `LinkedHashMap` to let `transform` in order.
   
   > this version is not very friendly to bump up the version of typesafe config.
   
   This is a big changes, so I will split this issue into two sub issues to help finish it, and it's be easier to understand.
   I will use `maven-shade-plugin` to shade `config` dependency in the next patch, https://github.com/leo65535/seatunnel/tree/config-shade
   
   ### Notice
   
   After this patch, the keys needs to use double quotation marks in the configuration file, like
   
   ```
   env {
     "spark.app.name" = "SeaTunnel"
     "spark.executor.instances" = 2
     "spark.executor.cores" = 1
     "spark.executor.memory" = "1g"
     "spark.streaming.batchDuration" = 5
   }
   
   sink {
     "a.b.c.Console" {}
   }
   ```
   
   ### Others
   
   Nothing else has changed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org