You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by hpandeycodeit <gi...@git.apache.org> on 2018/12/27 22:00:08 UTC
[GitHub] madlib pull request #343: Linear Regression: Support for JSON and special ch...
GitHub user hpandeycodeit opened a pull request:
https://github.com/apache/madlib/pull/343
Linear Regression: Support for JSON and special characters
JIRA: MADLIB-1284
- Modified code in linear.py_in to support special characters and JSON data type
- Written test case for JSON and Speacial characters
- Test case checks for JSON and special characters in GPDB 5.x and Special characters in GPDB 4.x
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hpandeycodeit/incubator-madlib MADLIB_1284
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/343.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #343
----
commit 179c936ade15558366b5c0aaf0eae8b744f8d492
Author: hpandeycodeit <hp...@...>
Date: 2018-12-27T21:55:48Z
Linear Regression: Support for JSON and special characters
JIRA: MADLIB-1284
- Modified code in linear.py_in to support special characters and JSON data type
- Written test case for JSON and Speacial characters
- Test case checks for JSON and special characters in GPDB 5.x and Special characters in GPDB 4.x
----
---
[GitHub] madlib issue #343: Linear Regression: Support for JSON and special character...
Posted by jingyimei <gi...@git.apache.org>.
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/343
@hpandeycodeit Can you please rebase this branch from master so that we can do full test? Thanks!
---
[GitHub] madlib issue #343: Linear Regression: Support for JSON and special character...
Posted by jingyimei <gi...@git.apache.org>.
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/343
Jenkins Ok to test
---
[GitHub] madlib issue #343: Linear Regression: Support for JSON and special character...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/343
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/721/
---
[GitHub] madlib issue #343: Linear Regression: Support for JSON and special character...
Posted by hpandeycodeit <gi...@git.apache.org>.
Github user hpandeycodeit commented on the issue:
https://github.com/apache/madlib/pull/343
@jingyimei I have fixed the linear regression one. Thanks!
---
[GitHub] madlib issue #343: Linear Regression: Support for JSON and special character...
Posted by jingyimei <gi...@git.apache.org>.
Github user jingyimei commented on the issue:
https://github.com/apache/madlib/pull/343
@hpandeycodeit Seems couple of dev check test cases failed in Jenkins build. Can you please look into them and fix? Thanks!
---
[GitHub] madlib pull request #343: Linear Regression: Support for JSON and special ch...
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/madlib/pull/343#discussion_r245022983
--- Diff: src/ports/postgres/modules/regress/linear.py_in ---
@@ -134,11 +170,11 @@ def linregr_train(schema_madlib, source_table, out_table,
'linregr'::varchar as method
, '{source_table}'::varchar as source_table
, '{out_table}'::varchar as out_table
- , '{dependent_varname}'::varchar as dependent_varname
- , '{independent_varname}'::varchar as independent_varname
+ , $${dependent_varname}$$::varchar as dependent_varname
+ , $${independent_varname}$$::varchar as independent_varname
, {num_rows_processed}::integer as num_rows_processed
, {num_rows_skipped}::integer as num_missing_rows_skipped
- , {grouping_col}::text as grouping_col
+ , $${grouping_col}$$::text as grouping_col
--- End diff --
These additional quotes around the grouping columns break the PMML tests.
---
[GitHub] madlib issue #343: Linear Regression: Support for JSON and special character...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/343
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/724/
---
[GitHub] madlib issue #343: Linear Regression: Support for JSON and special character...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/343
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/722/
---
[GitHub] madlib issue #343: Linear Regression: Support for JSON and special character...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/343
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/720/
---
[GitHub] madlib issue #343: Linear Regression: Support for JSON and special character...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/343
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/730/
---
[GitHub] madlib pull request #343: Linear Regression: Support for JSON and special ch...
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/madlib/pull/343#discussion_r245023325
--- Diff: src/ports/postgres/modules/regress/linear.py_in ---
@@ -185,10 +221,12 @@ def _validate_args(schema_madlib, source_table, out_table, dependent_varname,
if grouping_cols is not None:
_assert(grouping_cols != '',
"Linregr error: Invalid grouping columns name!")
+ # grouping columns can be a valid expression as well, for eg.
+ # a json expression (data->>'id'), so commenting this part.
grouping_list = _string_to_array_with_quotes(grouping_cols)
- _assert(columns_exist_in_table(
- source_table, grouping_list, schema_madlib),
- "Linregr error: Grouping column does not exist!")
+ #_assert(columns_exist_in_table(
--- End diff --
We should clean up these comments before the merge.
---
[GitHub] madlib issue #343: Linear Regression: Support for JSON and special character...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/343
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/726/
---