You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gabor Apati-Nagy <ga...@citrix.com> on 2014/10/28 20:16:03 UTC
Review Request 27296: CLOUDSTACK-7764: No IP Address Validations when
Adding Networks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27296/
-----------------------------------------------------------
Review request for cloudstack, Brian Federle and Jessica Wang.
Bugs: CLOUDSTACK-7764
https://issues.apache.org/jira/browse/CLOUDSTACK-7764
Repository: cloudstack-git
Description
-------
Networks Added validations for Add Network form on IPv4 Gateway, IPv4 Netmask, IPv4 Start IP, IPv4 End IP, IPv6 Gateway, IPv6 CIDR, IPv6 Start IP, IPv6 End IP fields.
Diffs
-----
ui/scripts/sharedFunctions.js 8ec88b392eefd35c1d0b133097d17c82c3d65549
Diff: https://reviews.apache.org/r/27296/diff/
Testing
-------
Tested validation on these fields.
Thanks,
Gabor Apati-Nagy
Re: Review Request 27296: CLOUDSTACK-7764: No IP Address Validations
when Adding Networks
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27296/#review58875
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Federle
On Oct. 28, 2014, 7:16 p.m., Gabor Apati-Nagy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27296/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 7:16 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-7764
> https://issues.apache.org/jira/browse/CLOUDSTACK-7764
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Networks Added validations for Add Network form on IPv4 Gateway, IPv4 Netmask, IPv4 Start IP, IPv4 End IP, IPv6 Gateway, IPv6 CIDR, IPv6 Start IP, IPv6 End IP fields.
>
>
> Diffs
> -----
>
> ui/scripts/sharedFunctions.js 8ec88b392eefd35c1d0b133097d17c82c3d65549
>
> Diff: https://reviews.apache.org/r/27296/diff/
>
>
> Testing
> -------
>
> Tested validation on these fields.
>
>
> Thanks,
>
> Gabor Apati-Nagy
>
>