You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "solrbot (via GitHub)" <gi...@apache.org> on 2023/02/26 22:47:25 UTC

[GitHub] [solr] solrbot opened a new pull request, #1405: Update dependency net.arnx:jsonic to v1.3.10

solrbot opened a new pull request, #1405:
URL: https://github.com/apache/solr/pull/1405

   This PR contains the following updates:
   
   | Package | Type | Update | Change |
   |---|---|---|---|
   | [net.arnx:jsonic](http://jsonic.sourceforge.jp/) ([source](http://svn.sourceforge.jp/svnroot/jsonic/)) | dependencies | minor | `1.2.7` -> `1.3.10` |
   
   ---
   
   ### Configuration
   
   📅 **Schedule**: Branch creation - "* * * * 0" (UTC), Automerge - At any time (no schedule defined).
   
   🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
   
   â™» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
   
   🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
   
   ---
   
    - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
   
   ---
   
   This PR has been generated by [Renovate Bot](https://togithub.com/solrbot/renovate-github-action)
   <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTIuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE1Mi4wIn0=-->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] risdenk commented on pull request #1405: Remove explicit net.arnx:jsonic from versions.props

Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #1405:
URL: https://github.com/apache/solr/pull/1405#issuecomment-1450901519

   @janhoy if you find more please point them out :D I had tried to cleanup versions.props in the past but could have missed some.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] risdenk commented on pull request #1405: Update dependency net.arnx:jsonic to v1.3.10

Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #1405:
URL: https://github.com/apache/solr/pull/1405#issuecomment-1450208635

   @janhoy any dependency we can remove from versions.props is a win. It looks like you are right that jsonic isn't referenced in our build.gradle files so should be possible to remove from versions.props.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] risdenk commented on pull request #1405: Update dependency net.arnx:jsonic to v1.3.10

Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #1405:
URL: https://github.com/apache/solr/pull/1405#issuecomment-1450215006

   I can push this change to remove that explicit line to this branch. Solr 8.11 had jsonic 1.2.7 and looks like it goes way back to 2013.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] janhoy commented on pull request #1405: Update dependency net.arnx:jsonic to v1.3.10

Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1405:
URL: https://github.com/apache/solr/pull/1405#issuecomment-1450142110

   This dependency is only used by langdetect (https://mvnrepository.com/artifact/com.cybozu.labs/langdetect) which had last release in 2012, thus references an old version of jsonic.
   
   Should we upgrade jsonic just for the hyigene factor, or remove it as an explicit line in `versions.props` and instead focus on replacing langdetect with another library that is actually maintained?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] solrbot commented on pull request #1405: Remove explicit net.arnx:jsonic from versions.props

Posted by "solrbot (via GitHub)" <gi...@apache.org>.
solrbot commented on PR #1405:
URL: https://github.com/apache/solr/pull/1405#issuecomment-1450261557

   ### Edited/Blocked Notification
   
   Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
   
   You can manually request rebase by checking the rebase/retry box above.
   
    âš  **Warning**: custom changes will be lost.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] janhoy commented on pull request #1405: Remove explicit net.arnx:jsonic from versions.props

Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1405:
URL: https://github.com/apache/solr/pull/1405#issuecomment-1450889509

   Thanks @risdenk . I think there are more of these, where we can remove our props line and let it be dealt with transitively, i.e. it's not a 1st party dep.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] risdenk merged pull request #1405: Remove explicit net.arnx:jsonic from versions.props

Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk merged PR #1405:
URL: https://github.com/apache/solr/pull/1405


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org