You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/07 05:58:07 UTC
[GitHub] [spark] BryanCutler opened a new pull request #29962: [SPARK-33073][PYTHON][3.0] Improve error handling on Pandas to Arrow conversion failures
BryanCutler opened a new pull request #29962:
URL: https://github.com/apache/spark/pull/29962
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This improves error handling when a failure in conversion from Pandas to Arrow occurs. And fixes tests to be compatible with upcoming Arrow 2.0.0 release.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Current tests will fail with Arrow 2.0.0 because of a change in error message when the schema is invalid. For these cases, the current error message also includes information on disabling safe conversion config, which is mainly meant for floating point truncation and overflow. The tests have been updated to use a message that is show for past Arrow versions, and upcoming.
If the user enters an invalid schema, the error produced by pyarrow is not consistent and either `TypeError` or `ArrowInvalid`, with the latter being caught, and raised as a `RuntimeError` with the extra info.
The error handling is improved by:
- narrowing the exception type to `TypeError`s, which `ArrowInvalid` is a subclass and what is raised on safe conversion failures.
- The exception is only raised with additional information on disabling "spark.sql.execution.pandas.convertToArrowArraySafely" if it is enabled in the first place.
- The original exception is chained to better show it to the user (only for Spark 3.1+ which requires Python 3)
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, the error re-raised changes from a RuntimeError to a ValueError, which better categorizes this type of error and in-line with the original Arrow error.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing tests, using pyarrow 1.0.1 and 2.0.0-snapshot, and Python 2 with 0.15.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29962: [SPARK-33073][PYTHON][3.0] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29962:
URL: https://github.com/apache/spark/pull/29962#issuecomment-704740867
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34098/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29962: [SPARK-33073][PYTHON][3.0] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29962:
URL: https://github.com/apache/spark/pull/29962#issuecomment-704770249
Merged to branch-3.0.
Thanks @BryanCutler and @dongjoon-hyun.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29962: [SPARK-33073][PYTHON][3.0] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29962:
URL: https://github.com/apache/spark/pull/29962#issuecomment-704712390
Thank you, @BryanCutler !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #29962: [SPARK-33073][PYTHON][3.0] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #29962:
URL: https://github.com/apache/spark/pull/29962
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] BryanCutler commented on pull request #29962: [SPARK-33073][PYTHON][3.0] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #29962:
URL: https://github.com/apache/spark/pull/29962#issuecomment-704712489
cc @HyukjinKwon @dongjoon-hyun , I tested this locally with Python 2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29962: [SPARK-33073][PYTHON][3.0] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29962:
URL: https://github.com/apache/spark/pull/29962#issuecomment-704713094
**[Test build #129492 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129492/testReport)** for PR 29962 at commit [`5c3c195`](https://github.com/apache/spark/commit/5c3c195d4d260a8497c898ce2910ed143bd19e1d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29962: [SPARK-33073][PYTHON][3.0] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29962:
URL: https://github.com/apache/spark/pull/29962#issuecomment-704727645
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29962: [SPARK-33073][PYTHON][3.0] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29962:
URL: https://github.com/apache/spark/pull/29962#issuecomment-704740896
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34098/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29962: [SPARK-33073][PYTHON][3.0] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29962:
URL: https://github.com/apache/spark/pull/29962#issuecomment-704727043
**[Test build #129492 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129492/testReport)** for PR 29962 at commit [`5c3c195`](https://github.com/apache/spark/commit/5c3c195d4d260a8497c898ce2910ed143bd19e1d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] BryanCutler commented on pull request #29962: [SPARK-33073][PYTHON][3.0] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #29962:
URL: https://github.com/apache/spark/pull/29962#issuecomment-705124351
Thanks @HyukjinKwon and @dongjoon-hyun !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29962: [SPARK-33073][PYTHON][3.0] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29962:
URL: https://github.com/apache/spark/pull/29962#issuecomment-704732330
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34098/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29962: [SPARK-33073][PYTHON][3.0] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29962:
URL: https://github.com/apache/spark/pull/29962#issuecomment-704740888
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29962: [SPARK-33073][PYTHON][3.0] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29962:
URL: https://github.com/apache/spark/pull/29962#issuecomment-704727645
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29962: [SPARK-33073][PYTHON][3.0] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29962:
URL: https://github.com/apache/spark/pull/29962#issuecomment-704713094
**[Test build #129492 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129492/testReport)** for PR 29962 at commit [`5c3c195`](https://github.com/apache/spark/commit/5c3c195d4d260a8497c898ce2910ed143bd19e1d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29962: [SPARK-33073][PYTHON][3.0] Improve error handling on Pandas to Arrow conversion failures
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29962:
URL: https://github.com/apache/spark/pull/29962#issuecomment-704740888
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org