You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2017/08/23 18:01:29 UTC
[kudu-CR] [java] Gradle test task improvements
Grant Henke has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7782
Change subject: [java] Gradle test task improvements
......................................................................
[java] Gradle test task improvements
Previously some tests would be extremely flaky when running via Gradle. Especially secure tests with token renewal. This fixes that issue by forking a new jvm for each test class to isolate the tests. I also add a few system properties to match the Maven build and support filtering tests from theroot directory with the --tests argument.
Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
---
M java/gradle/tests.gradle
1 file changed, 20 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/7782/1
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
[kudu-CR] [java] Gradle test task improvements
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change.
Change subject: [java] Gradle test task improvements
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7782/1//COMMIT_MSG
Commit Message:
PS1, Line 11:
: Change-Id: Ifb660b15423b68c299518b7ba5
> That's interesting -- tests other than TestAuthnTokenReacquire and TestAuth
I don't think this is a recent issue. The gradle tests had this issue since first introduced IIRC.
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [java] Gradle test task improvements
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change.
Change subject: [java] Gradle test task improvements
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7782/4/java/gradle/tests.gradle
File java/gradle/tests.gradle:
Line 42: systemProperty "java.security.egd", "file:/dev/./urandom" // Improve RNG generation speed.
> simplify to file:/dev/urandom ?
Yeah, I think I could. I wondered about that but left it since the maven pom had it this way.
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [java] Gradle test task improvements
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [java] Gradle test task improvements
......................................................................
Patch Set 5: Verified+1
Overriding Jenkins, looks like another ITClient deadlock which is currently being worked on.
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [java] Gradle test task improvements
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7782
to look at the new patch set (#3).
Change subject: [java] Gradle test task improvements
......................................................................
[java] Gradle test task improvements
Previously some tests would be extremely flaky whenrunning via Gradle. Especially secure tests with token renewal. This fixes that issue by forking a new jvm foreach test class to isolate the tests.I also add a few system properties to match theMaven build and support filtering tests from the root
directory with the --tests argument.
Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
---
M java/gradle/tests.gradle
1 file changed, 20 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/7782/3
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [java] Gradle test task improvements
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: [java] Gradle test task improvements
......................................................................
[java] Gradle test task improvements
Previously some tests would be extremely flaky whenrunning via Gradle. Especially secure tests with tokenrenewal. This fixes that issue by forking a new jvm foreach test class to isolate the tests.I also add a few system properties to match theMaven build and support filtering tests from the root
directory with the --tests argument.
Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Reviewed-on: http://gerrit.cloudera.org:8080/7782
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M java/gradle/tests.gradle
M java/pom.xml
2 files changed, 21 insertions(+), 2 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [java] Gradle test task improvements
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [java] Gradle test task improvements
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7782/1//COMMIT_MSG
Commit Message:
PS1, Line 11: d: Ifb660b15423b68c299518b7ba54a15135972a007
:
> Right now the one that fails consistently is TestHandleTooBusy.testMasterLo
OK, thanks for the info. I'll take a look at that tonight -- it's strange, indeed.
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [java] Gradle test task improvements
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7782
to look at the new patch set (#5).
Change subject: [java] Gradle test task improvements
......................................................................
[java] Gradle test task improvements
Previously some tests would be extremely flaky whenrunning via Gradle. Especially secure tests with tokenrenewal. This fixes that issue by forking a new jvm foreach test class to isolate the tests.I also add a few system properties to match theMaven build and support filtering tests from the root
directory with the --tests argument.
Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
---
M java/gradle/tests.gradle
M java/pom.xml
2 files changed, 21 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/7782/5
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [java] Gradle test task improvements
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [java] Gradle test task improvements
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7782/1//COMMIT_MSG
Commit Message:
Trailing whitespace.
PS1, Line 11: d: Ifb660b15423b68c299518b7ba54a15135972a007
:
Surefire doesn't do this in Maven (at least not within a module; there's a separate JVM per module though), so why should the Gradle-based tests be any more or less flaky by reusing a JVM?
IIRC reusing a JVM means the tests run faster.
http://gerrit.cloudera.org:8080/#/c/7782/1/java/gradle/tests.gradle
File java/gradle/tests.gradle:
Line 39: // Set a few system properties.
Should we also set -Xmx1900m? I see that in Maven's testArgLine property.
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [java] Gradle test task improvements
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [java] Gradle test task improvements
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7782/1//COMMIT_MSG
Commit Message:
PS1, Line 11: d: Ifb660b15423b68c299518b7ba54a15135972a007
:
> The root pom.xml sets reuseForks=false which means each test class executes
That's interesting -- tests other than TestAuthnTokenReacquire and TestAuthnTokenReacquireOpen should not be in a need to re-acquire authn tokens at all. I.e., they are not supposed to receive 'invalid token' response from the servers.
It might be something else in play. Maybe, that's because of some quirks with RPC found recently?
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [java] Gradle test task improvements
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [java] Gradle test task improvements
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7782/1//COMMIT_MSG
Commit Message:
PS1, Line 11: d: Ifb660b15423b68c299518b7ba54a15135972a007
:
> I don't think this is a recent issue. The gradle tests had this issue since
All right, but the servers are not supposed to send 'invalid token' responses in other tests at all.
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [java] Gradle test task improvements
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [java] Gradle test task improvements
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7782/1//COMMIT_MSG
Commit Message:
PS1, Line 11:
: Change-Id: Ifb660b15423b68c299518b7ba5
> The root pom.xml sets reuseForks=false which means each test class executes
Ah, I missed the reuseForks=false thing in pom.xml. Carry on then.
But yes, in general I think we should try to restore reuseForks=true since it should also yield faster running tests. Out of scope for this patch, obviously.
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [java] Gradle test task improvements
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change.
Change subject: [java] Gradle test task improvements
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7782/1//COMMIT_MSG
Commit Message:
PS1, Line 11: d: Ifb660b15423b68c299518b7ba54a15135972a007
:
> All right, but the servers are not supposed to send 'invalid token' respons
Right now the one that fails consistently is TestHandleTooBusy.testMasterLookupOverflow.
Also TestTimeouts.testLowTimeouts fails too, but that may be something else.
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [java] Gradle test task improvements
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7782
to look at the new patch set (#4).
Change subject: [java] Gradle test task improvements
......................................................................
[java] Gradle test task improvements
Previously some tests would be extremely flaky whenrunning via Gradle. Especially secure tests with tokenrenewal. This fixes that issue by forking a new jvm foreach test class to isolate the tests.I also add a few system properties to match theMaven build and support filtering tests from the root
directory with the --tests argument.
Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
---
M java/gradle/tests.gradle
1 file changed, 20 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/7782/4
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [java] Gradle test task improvements
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change.
Change subject: [java] Gradle test task improvements
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7782/1//COMMIT_MSG
Commit Message:
> Trailing whitespace.
Done
PS1, Line 11: d: Ifb660b15423b68c299518b7ba54a15135972a007
:
> Surefire doesn't do this in Maven (at least not within a module; there's a
The root pom.xml sets reuseForks=false which means each test class executes in its own JVM process according to documentation here:
http://maven.apache.org/surefire/maven-failsafe-plugin/examples/fork-options-and-parallel-execution.html
Without this change many tests fail with "cannot re-acquire authentication token after 5 attempts".
Removing reuseForks=false from the pom also causes similar errors.
That said, perhaps their is an issue with acquiring tokens in a shared jvm that should be looked at.
http://gerrit.cloudera.org:8080/#/c/7782/1/java/gradle/tests.gradle
File java/gradle/tests.gradle:
Line 39: // Set a few system properties.
> Should we also set -Xmx1900m? I see that in Maven's testArgLine property.
I saw that but had no failures as a result of memory issues. So I figured there was no reason to add it. We can always add it if we see issues.
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [java] Gradle test task improvements
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [java] Gradle test task improvements
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [java] Gradle test task improvements
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [java] Gradle test task improvements
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7782/4/java/gradle/tests.gradle
File java/gradle/tests.gradle:
PS4, Line 42: /./
simplify to file:/dev/urandom ?
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [java] Gradle test task improvements
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7782
to look at the new patch set (#2).
Change subject: [java] Gradle test task improvements
......................................................................
[java] Gradle test task improvements
Previously some tests would be extremely flaky when running via Gradle. Especially secure tests with token renewal. This fixes that issue by forking a new jvm foreach test class to isolate the tests.I also add a few system properties to match theMaven build and support filtering tests from the root
directory with the --tests argument.
Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
---
M java/gradle/tests.gradle
1 file changed, 20 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/7782/2
--
To view, visit http://gerrit.cloudera.org:8080/7782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb660b15423b68c299518b7ba54a15135972a007
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>