You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "Doğacan Güney (JIRA)" <ji...@apache.org> on 2007/06/16 13:01:25 UTC
[jira] Created: (NUTCH-499) Refactor LinkDb and LinkDbMerger to
reuse code
Refactor LinkDb and LinkDbMerger to reuse code
----------------------------------------------
Key: NUTCH-499
URL: https://issues.apache.org/jira/browse/NUTCH-499
Project: Nutch
Issue Type: Improvement
Components: linkdb
Reporter: Doğacan Güney
Assignee: Doğacan Güney
Priority: Trivial
LinkDb.Merger.reduce and LinkDb.reduce works the same way. Refactor Nutch so that we can use the same code for both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NUTCH-499) Refactor LinkDb and LinkDbMerger to
reuse code
Posted by "Doğacan Güney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508162 ]
Doğacan Güney commented on NUTCH-499:
-------------------------------------
Does anyone have any objections to the refactorings (Removal of LinkDb.Merger, and integrating its functionality to LinkDbMerger) ? If not, I am going to test this against trunk to make sure it works and then commit it.
> Refactor LinkDb and LinkDbMerger to reuse code
> ----------------------------------------------
>
> Key: NUTCH-499
> URL: https://issues.apache.org/jira/browse/NUTCH-499
> Project: Nutch
> Issue Type: Improvement
> Components: linkdb
> Reporter: Doğacan Güney
> Assignee: Doğacan Güney
> Priority: Trivial
> Attachments: NUTCH-499.patch
>
>
> LinkDb.Merger.reduce and LinkDb.reduce works the same way. Refactor Nutch so that we can use the same code for both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NUTCH-499) Refactor LinkDb and LinkDbMerger to
reuse code
Posted by "Sami Siren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508449 ]
Sami Siren commented on NUTCH-499:
----------------------------------
+1, seems good to me
> Refactor LinkDb and LinkDbMerger to reuse code
> ----------------------------------------------
>
> Key: NUTCH-499
> URL: https://issues.apache.org/jira/browse/NUTCH-499
> Project: Nutch
> Issue Type: Improvement
> Components: linkdb
> Reporter: Doğacan Güney
> Assignee: Doğacan Güney
> Priority: Trivial
> Attachments: NUTCH-499.patch
>
>
> LinkDb.Merger.reduce and LinkDb.reduce works the same way. Refactor Nutch so that we can use the same code for both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NUTCH-499) Refactor LinkDb and LinkDbMerger to
reuse code
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508749 ]
Hudson commented on NUTCH-499:
------------------------------
Integrated in Nutch-Nightly #131 (See [http://lucene.zones.apache.org:8080/hudson/job/Nutch-Nightly/131/])
> Refactor LinkDb and LinkDbMerger to reuse code
> ----------------------------------------------
>
> Key: NUTCH-499
> URL: https://issues.apache.org/jira/browse/NUTCH-499
> Project: Nutch
> Issue Type: Improvement
> Components: linkdb
> Reporter: Doğacan Güney
> Assignee: Doğacan Güney
> Priority: Trivial
> Fix For: 1.0.0
>
> Attachments: NUTCH-499.patch
>
>
> LinkDb.Merger.reduce and LinkDb.reduce works the same way. Refactor Nutch so that we can use the same code for both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NUTCH-499) Refactor LinkDb and LinkDbMerger to
reuse code
Posted by "Doğacan Güney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doğacan Güney updated NUTCH-499:
--------------------------------
Attachment: NUTCH-499.patch
* Remove LinkDb.Merger completely.
* Move LinkDb.reduce (LinkDb no longer implements Reducer) and LinkDb.createMergeJob to LinkDbMerger. I think it doesn't make much sense to have a LinkDb$Merger _and_ a LinkDbMerger so I merged them into one class.
> Refactor LinkDb and LinkDbMerger to reuse code
> ----------------------------------------------
>
> Key: NUTCH-499
> URL: https://issues.apache.org/jira/browse/NUTCH-499
> Project: Nutch
> Issue Type: Improvement
> Components: linkdb
> Reporter: Doğacan Güney
> Assignee: Doğacan Güney
> Priority: Trivial
> Attachments: NUTCH-499.patch
>
>
> LinkDb.Merger.reduce and LinkDb.reduce works the same way. Refactor Nutch so that we can use the same code for both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (NUTCH-499) Refactor LinkDb and LinkDbMerger to
reuse code
Posted by "Doğacan Güney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doğacan Güney resolved NUTCH-499.
---------------------------------
Resolution: Fixed
Fix Version/s: 1.0.0
Committed in rev. 551098.
> Refactor LinkDb and LinkDbMerger to reuse code
> ----------------------------------------------
>
> Key: NUTCH-499
> URL: https://issues.apache.org/jira/browse/NUTCH-499
> Project: Nutch
> Issue Type: Improvement
> Components: linkdb
> Reporter: Doğacan Güney
> Assignee: Doğacan Güney
> Priority: Trivial
> Fix For: 1.0.0
>
> Attachments: NUTCH-499.patch
>
>
> LinkDb.Merger.reduce and LinkDb.reduce works the same way. Refactor Nutch so that we can use the same code for both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (NUTCH-499) Refactor LinkDb and LinkDbMerger to
reuse code
Posted by "Doğacan Güney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doğacan Güney closed NUTCH-499.
-------------------------------
Issue resolved and committed.
> Refactor LinkDb and LinkDbMerger to reuse code
> ----------------------------------------------
>
> Key: NUTCH-499
> URL: https://issues.apache.org/jira/browse/NUTCH-499
> Project: Nutch
> Issue Type: Improvement
> Components: linkdb
> Reporter: Doğacan Güney
> Assignee: Doğacan Güney
> Priority: Trivial
> Fix For: 1.0.0
>
> Attachments: NUTCH-499.patch
>
>
> LinkDb.Merger.reduce and LinkDb.reduce works the same way. Refactor Nutch so that we can use the same code for both.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.