[GitHub] [pulsar] madhavan-narayanan commented on a change in pull request #12536: [pulsar-broker] Broker extensions to allow operators of enterprise wide cluster better control and flexibility

[GitBox <gi...@apache.org>]

madhavan-narayanan commented on a change in pull request #12536:
URL: https://github.com/apache/pulsar/pull/12536#discussion_r739640873



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -1008,6 +1008,11 @@
     )
     private boolean disableBrokerInterceptors = true;
 
+    @FieldContext(
+            category = CATEGORY_SERVER,
+            doc = "List of interceptors for payload processing.")
+    private String brokerEntryPayloadProcessor;

Review comment:
       I will fix it. Thanks for catching this.

##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/EntryImpl.java
##########
@@ -47,12 +48,22 @@ protected EntryImpl newObject(Handle<EntryImpl> handle) {
     ByteBuf data;
 
     public static EntryImpl create(LedgerEntry ledgerEntry) {
+        return create(ledgerEntry,null);
+    }
+
+    public static EntryImpl create(LedgerEntry ledgerEntry, ManagedLedgerInterceptor managedLedgerInterceptor) {

Review comment:
       I extended the create() to ensure that future usages of this method from other places don't miss out the interceptor. 
   I do agree that it will be clean to have the calling methods process the ledger entry using interceptors and pass the result.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org