You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2017/06/08 15:22:59 UTC
[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7115
Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
......................................................................
IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
IMPALA-3040 was initially fixed to use a timeout with HDFS caching
tests, however some test executions against slow-running builds such as
ASAN indicate this timeout may not be high enough.
Use the specific_build_type_timeout() method to set a much higher
timeout for slower builds such as ASAN. This allows us to virtually
ignore timeout values on slow builds, but doesn't force us to
undconditionally increase the timeout in a release or debug build.
Testing:
Ran all tests that use get_num_cache_requests() in a loop 100 times each
under an ASAN build. All test iterations passed.
Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
---
M tests/query_test/test_hdfs_caching.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/7115/1
--
To view, visit http://gerrit.cloudera.org:8080/7115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
......................................................................
IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
IMPALA-3040 was initially fixed to use a timeout with HDFS caching
tests, however some test executions against slow-running builds such as
ASAN indicate this timeout may not be high enough.
Use the specific_build_type_timeout() method to set a much higher
timeout for slower builds such as ASAN. This allows us to virtually
ignore timeout values on slow builds, but doesn't force us to
unconditionally increase the timeout in a release or debug build.
Testing:
Ran all tests that use get_num_cache_requests() in a loop 100 times each
under an ASAN build. All test iterations passed.
Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Reviewed-on: http://gerrit.cloudera.org:8080/7115
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/query_test/test_hdfs_caching.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Michael Brown: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7115/1//COMMIT_MSG
Commit Message:
PS1, Line 16: undconditionally
typo
--
To view, visit http://gerrit.cloudera.org:8080/7115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
......................................................................
Patch Set 4:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/770/
--
To view, visit http://gerrit.cloudera.org:8080/7115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
......................................................................
Patch Set 3: Verified-1
Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/755/
--
To view, visit http://gerrit.cloudera.org:8080/7115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
......................................................................
Patch Set 3:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/755/
--
To view, visit http://gerrit.cloudera.org:8080/7115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7115
to look at the new patch set (#2).
Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
......................................................................
IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
IMPALA-3040 was initially fixed to use a timeout with HDFS caching
tests, however some test executions against slow-running builds such as
ASAN indicate this timeout may not be high enough.
Use the specific_build_type_timeout() method to set a much higher
timeout for slower builds such as ASAN. This allows us to virtually
ignore timeout values on slow builds, but doesn't force us to
unconditionally increase the timeout in a release or debug build.
Testing:
Ran all tests that use get_num_cache_requests() in a loop 100 times each
under an ASAN build. All test iterations passed.
Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
---
M tests/query_test/test_hdfs_caching.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/7115/2
--
To view, visit http://gerrit.cloudera.org:8080/7115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
......................................................................
Patch Set 2:
(1 comment)
Thanks for the review, Thomas. See PS2.
http://gerrit.cloudera.org:8080/#/c/7115/1//COMMIT_MSG
Commit Message:
PS1, Line 16: unconditionally
> typo
Done
--
To view, visit http://gerrit.cloudera.org:8080/7115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
......................................................................
Patch Set 3:
> Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/755/
Looks like IMPALA-5530.
--
To view, visit http://gerrit.cloudera.org:8080/7115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: No