You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/01 18:44:03 UTC
[GitHub] [pulsar] merlimat opened a new pull request #7130: MockZooKeeper shouldn't 'execute' while holding lock
merlimat opened a new pull request #7130:
URL: https://github.com/apache/pulsar/pull/7130
### Motivation
There was one particular bad code path where `MockZooKeeper#delete`
acquires the state mutex, submits to the executor and then releases
the lock. Normally this would be fine. However, `MockZooKeeper` is often
constructed with a direct executor. This means that the lock is still
held by the delete when it's acquired in the executed code block. So
even if we release before calling callbacks, the lock will still be
held until the end of the `#delete()` call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #7130: MockZooKeeper shouldn't 'execute' while holding lock
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #7130:
URL: https://github.com/apache/pulsar/pull/7130
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org