You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/02 17:28:42 UTC
[GitHub] codecov-io edited a comment on issue #5100: Fix form data issue
switching viz types
codecov-io edited a comment on issue #5100: Fix form data issue switching viz types
URL: https://github.com/apache/incubator-superset/pull/5100#issuecomment-392976283
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5100?src=pr&el=h1) Report
> Merging [#5100](https://codecov.io/gh/apache/incubator-superset/pull/5100?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/df5ce50e80fe83f4ed2551b1147d07c7ad1d7a95?src=pr&el=desc) will **decrease** coverage by `1.25%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5100?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5100 +/- ##
==========================================
- Coverage 61.32% 60.07% -1.26%
==========================================
Files 369 369
Lines 23483 24023 +540
Branches 2717 2715 -2
==========================================
+ Hits 14401 14431 +30
- Misses 9070 9580 +510
Partials 12 12
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5100?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ts/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5100/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZVZpZXdDb250YWluZXIuanN4) | `0% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5100/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `47.32% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/5100/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3N0b3JlLmpz) | `24.63% <ø> (+1.35%)` | :arrow_up: |
| [superset/assets/src/explore/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/5100/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3Zpc1R5cGVzLmpz) | `55.55% <ø> (ø)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5100/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.96% <100%> (ø)` | :arrow_up: |
| [superset/data/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/5100/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9jb3VudHJpZXMucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5100/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `63.91% <0%> (-17.47%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5100/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `68.98% <0%> (-9.15%)` | :arrow_down: |
| [...rset/assets/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/incubator-superset/pull/5100/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvYWN0aW9ucy9zbGljZUVudGl0aWVzLmpz) | `28.57% <0%> (-1.74%)` | :arrow_down: |
| [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/5100/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.6% <0%> (-0.21%)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/5100/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5100?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5100?src=pr&el=footer). Last update [df5ce50...c835031](https://codecov.io/gh/apache/incubator-superset/pull/5100?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org