[GitHub] [openwhisk] steffenrost commented on a change in pull request #4564: Add reason parameter for wskadmin tool

[GitBox <gi...@apache.org>]

steffenrost commented on a change in pull request #4564: Add reason parameter for wskadmin tool
URL: https://github.com/apache/openwhisk/pull/4564#discussion_r323696200
 
 

 ##########
 File path: tools/admin/wskadmin
 ##########
 @@ -552,6 +553,11 @@ def setLimitsCmd(args, props):
         toSet = givenLimit if givenLimit != None else doc.get(limit)
         if toSet != None:
             doc[limit] = toSet
+    # setting reason
+    givenReason = argsDict.get('reason')
+    toSet = givenReason if givenReason != None else doc.get('reason')
+    if toSet != None:
+        doc['reason'] = toSet
 
 Review comment:
   In our product we store the `reason` along with the limits on the IAM resource. In my opinion attaching a `reason` to the `limits` document is a reasonable approach for the Openwhisk reference implementation.
   Your proposal to cap the length of the reason message make sense, I will update the PR accordingly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services