You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2009/02/24 14:17:58 UTC
encode-output="false" for display type="currency"
In revision: 747364, I had to introduce encode-output="false" for display type="currency" in ListInventoryAverageCosts form. Let me explain quickly why.
In France (for instance) we use now space as thousands separator
So I had to not encode output. But there are 75 occurrences of <<display type="currency">> in OFBiz forms.
So my question, should we not rather change something at ModelFormField.java[763] ?
Thanks
Jacques
Re: encode-output="false" for display type="currency"
Posted by Jacques Le Roux <ja...@les7arts.com>.
Fixed in at revision: 748803
Jacques
From: "Jacques Le Roux" <ja...@les7arts.com>
> Afterthought : I think I was not clear enough
>
> By default encode-output is true for display fields. If the type is currency an amount like 1260 will be rendered as US$1,260.00
> in USA but should be rendered 1 260,00 $ in France.
>
> So with encoding an is introduced in place of the space. And finally it's not rendered as 1 260,00 $ but as 1,00 $
> which is ... false!
>
> So I want to generalise (without using encode-output="false") and introduce a specific change for that at
> ModelFormField.java[763]. Without any comments I will do it tomorrow
>
> Jacques
>
> From: "Jacques Le Roux" <ja...@les7arts.com>
> In revision: 747364, I had to introduce encode-output="false" for display type="currency" in ListInventoryAverageCosts form. Let
> me explain quickly why.
>
> In France (for instance) we use now space as thousands separator
> So I had to not encode output. But there are 75 occurrences of <<display type="currency">> in OFBiz forms.
>
> So my question, should we not rather change something at ModelFormField.java[763] ?
>
> Thanks
>
> Jacques
>
Re: encode-output="false" for display type="currency"
Posted by Jacques Le Roux <ja...@les7arts.com>.
Afterthought : I think I was not clear enough
By default encode-output is true for display fields. If the type is currency an amount like 1260 will be rendered as US$1,260.00 in
USA but should be rendered 1 260,00 $ in France.
So with encoding an is introduced in place of the space. And finally it's not rendered as 1 260,00 $ but as 1,00 $ which
is ... false!
So I want to generalise (without using encode-output="false") and introduce a specific change for that at ModelFormField.java[763].
Without any comments I will do it tomorrow
Jacques
From: "Jacques Le Roux" <ja...@les7arts.com>
In revision: 747364, I had to introduce encode-output="false" for display type="currency" in ListInventoryAverageCosts form. Let me
explain quickly why.
In France (for instance) we use now space as thousands separator
So I had to not encode output. But there are 75 occurrences of <<display type="currency">> in OFBiz forms.
So my question, should we not rather change something at ModelFormField.java[763] ?
Thanks
Jacques