You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/11/05 17:05:19 UTC
Review Request 71722: Improved error reporting in
'Resources::pushReservation()'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71722/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
Make sure to print the actual error message after an assertion
failure in `Resources::pushReservations()`.
Diffs
-----
src/common/resources.cpp bfa9f3ea7e8c3e2dc9b4c4f7c86ad29b0de81f24
Diff: https://reviews.apache.org/r/71722/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 71722: Improved error reporting in
'Resources::pushReservation()'.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71722/#review218566
-----------------------------------------------------------
Ship it!
Thanks for this, I remember having patched that in for development repeatedly.
- Benjamin Bannier
On Nov. 5, 2019, 6:05 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71722/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2019, 6:05 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Make sure to print the actual error message after an assertion
> failure in `Resources::pushReservations()`.
>
>
> Diffs
> -----
>
> src/common/resources.cpp bfa9f3ea7e8c3e2dc9b4c4f7c86ad29b0de81f24
>
>
> Diff: https://reviews.apache.org/r/71722/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 71722: Improved error reporting in
'Resources::pushReservation()'.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71722/#review218514
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71722]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Nov. 5, 2019, 5:05 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71722/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2019, 5:05 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Make sure to print the actual error message after an assertion
> failure in `Resources::pushReservations()`.
>
>
> Diffs
> -----
>
> src/common/resources.cpp bfa9f3ea7e8c3e2dc9b4c4f7c86ad29b0de81f24
>
>
> Diff: https://reviews.apache.org/r/71722/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>