You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "Pearl1594 (via GitHub)" <gi...@apache.org> on 2023/08/10 01:43:23 UTC

[GitHub] [cloudstack-cloudmonkey] Pearl1594 opened a new pull request, #140: Convert GET to POST requests

Pearl1594 opened a new pull request, #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-cloudmonkey] hrak commented on pull request #140: Convert GET to POST requests

Posted by "hrak (via GitHub)" <gi...@apache.org>.
hrak commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1674302140

   > @hrak did you face issues when using the deploy VM API or other user-data related APIs? 
   
   Yes, i can't submit userdata > 4K using Cloudmonkey.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Convert GET to POST requests [cloudstack-cloudmonkey]

Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1791029733

   @DaanHoogland @Pearl1594 is there a way you could test against large userdata input string to see how it behaves wrt post vs get request?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Convert GET to POST requests [cloudstack-cloudmonkey]

Posted by "mlsorensen (via GitHub)" <gi...@apache.org>.
mlsorensen commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1779608937

   FYI - I tested this out and am getting auth errors via keys if I try to call `deploy virtualmachine` or `update virtualmachine` with large userdata. 
   
   ```
   % ./cmk
   Apache CloudStack 🐵 CloudMonkey 6.4.0-rc
   Report issues: https://github.com/apache/cloudstack-cloudmonkey/issues
   
   🐱 > deploy virtualmachine ...
   
   🙈 Error: failed to authenticate, please check the credentials
   ```
   
   I did not run in debug mode so I didn't capture that output, but retrying without the userdata worked. Then trying to `update virtualmachine` to apply the userdata afterword failed with same error.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Convert GET to POST requests [cloudstack-cloudmonkey]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1795151344

   liberally stealing from my chat with @Pearl1594;
   before : 
   ```
   (nsx) 🐱 > deploy virtualmachine name=test-cmk-post-ud serviceofferingid=cbbe6556-3bdb-4bc7-92f6-93abc628e69e  templateid=73c7dddb-77ee-11ee-863b-1e0093000c63  zoneid=daa697fd-5629-4623-97d4-af4297f2dc16  userdata="cXdlcnR5dWlvcGFzZGZnaGprbHp4Y3Zibm1xd2VydHl1aW9wYXNkZmdoamtsenhjdmJubXF3ZXJ0eXVpb3Bhc2RmZ2hqa2x4Y2JubSxxd2VydHl1aW9wc2RmZ2hqa2x6eGN2Ym5tcXdlcnR5dWlvZGZnaGprbHp4Y3Zibm1xd2VydHl1aW9wc2RmZ2hqa2x6eGN2Ym5tb3Bhc2RmZ2prenhjdmJubXF3ZXJ0eXVvc2RmZ2hqa2x6eGJubXF3ZXJycnJpaWlpaWlpaWlpaWlpaWlpaWlpaWlpdHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRvcGFzZG
 Znamt6eGN2Ym5tcXdlcnR5dW9zZGZnaGprbHp4Ym5tcXdlcnJycmlpaWlpaWlpaWlpaWlpaWlpaWlpaWl0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dG9wYXNkZmdqa3p4Y3Zibm1xd2VydHl1b3NkZmdoamtsenhibm1xd2VycnJyaWlpaWlpaWlpaWlpaWlpaWlpaWlpaXR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR
 0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0b3Bhc2RmZ2prenhjdmJubXF3ZXJ0eXVvc2RmZ2hqa2x6eGJubXF3ZXJycnJpaWlpaWlpaWlpaWlpaWlpaWlpaWlpdHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRvcGFzZGZnamt6eGN2Ym5tcXdlcnR5dW9zZGZnaGprbHp4Ym5tcXdlcnJycmlpaWlpaWlpaWlpaWlpaWlpaWlpaWl0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0
 dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dG9wYXNkZmdqa3p4Y3Zibm1xd2VydHl1b3NkZmdoamtsenhibm1xd2VycnJyaWlpaWlpaWlpaWlpaWlpaWlpaWlpaXR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0cXdlcnR5dWlvcGFzZGZnaGprbHp4Y3Zibm1xd2VydHl1aW9wYXNkZmdoamtsenhjdmJubXF3ZXJ0eXVpb3Bhc2RmZ2hqa2x4Y2JubSxxd2VydHl1aW9wc2RmZ2hqa2x6eGN2Ym5tcXdlcnR5dWlvZGZnaGprbHp4Y3Zibm1xd2VydHl1aW9wc2RmZ2hqa2x6eGN2Ym5tb3Bhc2RmZ2prenhjdmJubXF3ZXJ0eXVvc2RmZ2hqa2x6eGJubXF3ZXJycnJpaWlpaWlpaWlpaWlpaWlpaWlpaWlpdHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0d
 HR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRvcGFzZGZnamt6eGN2Ym5tcXdlcnR5dW9zZGZnaGprbHp4Ym5tcXdlcnJycmlpaWlpaWlpaWlpaWlpaWlpaWlpaWl0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dG9wYXNkZmdqa3
 p4Y3Zibm1xd2VydHl1b3NkZmdoamtsenhibm1xd2VycnJyaWlpaWlpaWlpaWlpaWlpaWlpaWlpaXR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0b3Bhc2RmZ2prenhjdmJubXF3ZXJ0eXVvc2RmZ2hqa2x6eGJubXF3ZXJycnJpaWlpaWlpaWlpaWlpaWlpaWlpaWlpdHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR
 0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRvcGFzZGZnamt6eGN2Ym5tcXdlcnR5dW9zZGZnaGprbHp4Ym5tcXdlcnJycmlpaWlpaWlpaWlpaWlpaWlpaWlpaWl0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dG9wYXNkZmdqa3p4Y3Zibm1xd2VydHl1b3NkZmdoamtsenhibm1xd2VycnJyaWlpaWlpaWlpaWlpaWlpaWlpaWlpaXR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0
 dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0" networkids=70522d4a-0d14-435c-82e0-8205c5bd16a2 
   🙈 Error: (HTTP 431, error code 4350) User data is too long for an http GET request
   ```
   
   after:
   ```
   (nsx) 🐱 > deploy virtualmachine name=test-cmk-post-ud2 serviceofferingid=cbbe6556-3bdb-4bc7-92f6-93abc628e69e  templateid=73c7dddb-77ee-11ee-863b-1e0093000c63  zoneid=daa697fd-5629-4623-97d4-af4297f2dc16  userdata="cXdlcnR5dWlvcGFzZGZnaGprbHp4Y3Zibm1xd2VydHl1aW9wYXNkZmdoamtsenhjdmJubXF3ZXJ0eXVpb3Bhc2RmZ2hqa2x4Y2JubSxxd2VydHl1aW9wc2RmZ2hqa2x6eGN2Ym5tcXdlcnR5dWlvZGZnaGprbHp4Y3Zibm1xd2VydHl1aW9wc2RmZ2hqa2x6eGN2Ym5tb3Bhc2RmZ2prenhjdmJubXF3ZXJ0eXVvc2RmZ2hqa2x6eGJubXF3ZXJycnJpaWlpaWlpaWlpaWlpaWlpaWlpaWlpdHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRvcGFzZ
 GZnamt6eGN2Ym5tcXdlcnR5dW9zZGZnaGprbHp4Ym5tcXdlcnJycmlpaWlpaWlpaWlpaWlpaWlpaWlpaWl0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dG9wYXNkZmdqa3p4Y3Zibm1xd2VydHl1b3NkZmdoamtsenhibm1xd2VycnJyaWlpaWlpaWlpaWlpaWlpaWlpaWlpaXR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dH
 R0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0b3Bhc2RmZ2prenhjdmJubXF3ZXJ0eXVvc2RmZ2hqa2x6eGJubXF3ZXJycnJpaWlpaWlpaWlpaWlpaWlpaWlpaWlpdHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRvcGFzZGZnamt6eGN2Ym5tcXdlcnR5dW9zZGZnaGprbHp4Ym5tcXdlcnJycmlpaWlpaWlpaWlpaWlpaWlpaWlpaWl0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR
 0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dG9wYXNkZmdqa3p4Y3Zibm1xd2VydHl1b3NkZmdoamtsenhibm1xd2VycnJyaWlpaWlpaWlpaWlpaWlpaWlpaWlpaXR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0cXdlcnR5dWlvcGFzZGZnaGprbHp4Y3Zibm1xd2VydHl1aW9wYXNkZmdoamtsenhjdmJubXF3ZXJ0eXVpb3Bhc2RmZ2hqa2x4Y2JubSxxd2VydHl1aW9wc2RmZ2hqa2x6eGN2Ym5tcXdlcnR5dWlvZGZnaGprbHp4Y3Zibm1xd2VydHl1aW9wc2RmZ2hqa2x6eGN2Ym5tb3Bhc2RmZ2prenhjdmJubXF3ZXJ0eXVvc2RmZ2hqa2x6eGJubXF3ZXJycnJpaWlpaWlpaWlpaWlpaWlpaWlpaWlpdHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0
 dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRvcGFzZGZnamt6eGN2Ym5tcXdlcnR5dW9zZGZnaGprbHp4Ym5tcXdlcnJycmlpaWlpaWlpaWlpaWlpaWlpaWlpaWl0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dG9wYXNkZmdqa
 3p4Y3Zibm1xd2VydHl1b3NkZmdoamtsenhibm1xd2VycnJyaWlpaWlpaWlpaWlpaWlpaWlpaWlpaXR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0b3Bhc2RmZ2prenhjdmJubXF3ZXJ0eXVvc2RmZ2hqa2x6eGJubXF3ZXJycnJpaWlpaWlpaWlpaWlpaWlpaWlpaWlpdHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dH
 R0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHRvcGFzZGZnamt6eGN2Ym5tcXdlcnR5dW9zZGZnaGprbHp4Ym5tcXdlcnJycmlpaWlpaWlpaWlpaWlpaWlpaWlpaWl0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dG9wYXNkZmdqa3p4Y3Zibm1xd2VydHl1b3NkZmdoamtsenhibm1xd2VycnJyaWlpaWlpaWlpaWlpaWlpaWlpaWlpaXR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR
 0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0dHR0" networkids=70522d4a-0d14-435c-82e0-8205c5bd16a2
   {
     "virtualmachine": {
       "account": "admin",
       "affinitygroup": [],
       "cpunumber": 1,
       "cpuspeed": 500,
       "created": "2023-11-06T14:41:34+0000",
       "details": {
         "cpuOvercommitRatio": "2.0",
         "dataDiskController": "osdefault",
         "memoryOvercommitRatio": "1.0",
         "rootDiskController": "ide"
       },
       "displayname": "test-cmk-post-ud2",
       "displayvm": true,
       "domain": "ROOT",
       "domainid": "73c14442-77ee-11ee-863b-1e0093000c63",
       "guestosid": "73caacda-77ee-11ee-863b-1e0093000c63",
       "haenable": false,
       "hasannotations": false,
       "hostcontrolstate": "Enabled",
       "hostid": "9b1c77c0-63ee-40d4-83d7-13aa3d6ad5c6",
       "hostname": "env03esx02.ll",
       "hypervisor": "VMware",
       "id": "63e53a5f-03a6-4483-be22-d8faf47af912",
       "instancename": "i-2-84-VM",
       "isdynamicallyscalable": false,
       "jobid": "ff2b625d-fb28-48a9-a8fc-2b71397b35c2",
       "jobstatus": 0,
       "lastupdated": "2023-11-06T14:41:53+0000",
       "memory": 512,
       "name": "test-cmk-post-ud2",
       "nic": [
         {
           "broadcasturi": "nsx://nsx",
           "deviceid": "0",
           "extradhcpoption": [],
           "gateway": "10.1.1.1",
           "id": "33de3a4d-214b-49ab-9848-d88cf8fca5ca",
           "ipaddress": "10.1.1.158",
           "isdefault": true,
           "isolationuri": "nsx://nsx",
           "macaddress": "02:01:00:d7:00:06",
           "netmask": "255.255.255.0",
           "networkid": "70522d4a-0d14-435c-82e0-8205c5bd16a2",
           "networkname": "iso1",
           "secondaryip": [],
           "traffictype": "Guest",
           "type": "Isolated"
         }
       ],
       "osdisplayname": "CentOS 5.3 (64-bit)",
       "ostypeid": "73caacda-77ee-11ee-863b-1e0093000c63",
       "passwordenabled": false,
       "pooltype": "NetworkFilesystem",
       "receivedbytes": 0,
       "rootdeviceid": 0,
       "rootdevicetype": "ROOT",
       "securitygroup": [],
       "sentbytes": 0,
       "serviceofferingid": "cbbe6556-3bdb-4bc7-92f6-93abc628e69e",
       "serviceofferingname": "Small Instance",
       "state": "Running",
       "tags": [],
       "templatedisplaytext": "CentOS 5.3(64-bit) no GUI (vSphere)",
       "templateid": "73c7dddb-77ee-11ee-863b-1e0093000c63",
       "templatename": "CentOS 5.3(64-bit) no GUI (vSphere)",
       "templatetype": "BUILTIN",
       "userid": "a13b78f5-77ee-11ee-863b-1e0093000c63",
       "username": "admin",
       "zoneid": "daa697fd-5629-4623-97d4-af4297f2dc16",
       "zonename": "ZoneNSX"
     }
   }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-cloudmonkey] Pearl1594 commented on pull request #140: Convert GET to POST requests

Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1672922905

   @weizhouapache @rohityadavcloud I was just testing to see if there is any issue with using POST for all commands. Hence raised this draft PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-cloudmonkey] weizhouapache commented on pull request #140: Convert GET to POST requests

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1674787609

   > @Pearl1594 I suppose a simple fix could be something like if the request size is say > 2048 or > 4096 then use POST, otherwise use GET. One thing we must check if when we use POST APIs, does cloudstack log them (for debugging/support purposes).
   
   or use POST if `userdata` or `password` is passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Convert GET to POST requests [cloudstack-cloudmonkey]

Posted by "mlsorensen (via GitHub)" <gi...@apache.org>.
mlsorensen commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1761419545

   Can we get a config item for the user to choose POST or not e.g. `set method [post|get]`?  This may be desirable for other calls that may contain large payload or secret data (like `addHost`), and it may be easier to provide generic functionality even if it makes the user have an alternate profile.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Convert GET to POST requests [cloudstack-cloudmonkey]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#discussion_r1380289018


##########
cmd/network.go:
##########
@@ -243,9 +252,18 @@ func NewAPIRequest(r *Request, api string, args []string, isAsync bool) (map[str
 		params.Add("sessionkey", sessionKey)
 		requestURL = fmt.Sprintf("%s?%s", r.Config.ActiveProfile.URL, encodeRequestParams(params))
 		config.Debug("NewAPIRequest API request URL:", requestURL)
-		response, err = r.Client().Get(requestURL)
-		if err != nil {
-			return nil, err
+
+		if params.Has("password") || params.Has("userdata") {
+			requestURL = fmt.Sprintf("%s", r.Config.ActiveProfile.URL)
+			response, err = r.Client().PostForm(requestURL, params)
+			if err != nil {
+				return nil, err
+			}
+		} else {
+			response, err = r.Client().Get(requestURL)
+			if err != nil {
+				return nil, err
+			}
 		}

Review Comment:
   this change is done twice. time for a method to call in both places?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-cloudmonkey] hrak commented on pull request #140: Convert GET to POST requests

Posted by "hrak (via GitHub)" <gi...@apache.org>.
hrak commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1674300784

   cloudstack-go also uses POST by default for both [DeployVirtualMachine](https://github.com/apache/cloudstack-go/blob/71cac076895025f9c830e4b7fbe0322a4dd369e0/cloudstack/VirtualMachineService.go#L2114) and [UpdateVirtualMachine](https://github.com/apache/cloudstack-go/blob/71cac076895025f9c830e4b7fbe0322a4dd369e0/cloudstack/VirtualMachineService.go#L7946)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Convert GET to POST requests [cloudstack-cloudmonkey]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1794876078

   after a short discuss off(this)line with @Pearl1594 , the performance is not very relevant as with only 2kb of url length userdata is going to be too long easily. If we wish we can implement a flag to try get first or a flag to use get (or post) for deploymachine. I think this is out of scope for this PR, though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Convert GET to POST requests [cloudstack-cloudmonkey]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-cloudmonkey] weizhouapache commented on pull request #140: Convert GET to POST requests

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1672588370

   @Pearl1594 
   just for your information, cloudstack UI sends POST request if userdata is present.
   ```
           const httpMethod = deployVmData.userdata ? 'POST' : 'GET'
           const args = httpMethod === 'POST' ? {} : deployVmData
           const data = httpMethod === 'POST' ? deployVmData : {}
   
           api('deployVirtualMachine', args, httpMethod, data).then(response => {
   ```
   see https://github.com/apache/cloudstack/blob/main/ui/src/views/compute/DeployVM.vue#L2167-L2171
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Convert GET to POST requests [cloudstack-cloudmonkey]

Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1782352212

   @mlsorensen can you share a test userdata string/content for us to test/reproduce it? Could you also check mgmt server logs (share the same)? It could be a limitation/issue in cmk or backend mgmt server.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Convert GET to POST requests [cloudstack-cloudmonkey]

Posted by "mlsorensen (via GitHub)" <gi...@apache.org>.
mlsorensen commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1779610165

   FYI - I tested this out and am getting auth errors via keys if I try to call `deploy virtualmachine` or `update virtualmachine` with large userdata. 
   
   ```
   % ./cmk
   Apache CloudStack 🐵 CloudMonkey 6.4.0-rc
   Report issues: https://github.com/apache/cloudstack-cloudmonkey/issues
   
   🐱 > deploy virtualmachine ...
   
   🙈 Error: failed to authenticate, please check the credentials
   ```
   
   I did not run in debug mode so I didn't capture that output, but retrying without the userdata worked. Then trying to `update virtualmachine` to apply the userdata afterword failed with same error.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-cloudmonkey] rohityadavcloud commented on pull request #140: Convert GET to POST requests

Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1674671520

   @Pearl1594  I suppose a simple fix could be something like if the request size is say > 2048 or > 4096 then use POST, otherwise use GET. One thing we must check if when we use POST APIs, does cloudstack log them (for debugging/support purposes).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-cloudmonkey] weizhouapache commented on pull request #140: Convert GET to POST requests

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1680094309

   @hrak 
   can you please test this ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-cloudmonkey] Pearl1594 commented on pull request #140: Convert GET to POST requests

Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1674539087

   @rohityadavcloud No, deployVM is a GET request. I'll identify the commands that use POST and update the PR, that said, all operations seem to work fine using post 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-cloudmonkey] rohityadavcloud commented on pull request #140: Convert GET to POST requests

Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1674303600

   @Pearl1594 isn't deploy VM using POST in cmk?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-cloudmonkey] rohityadavcloud commented on pull request #140: Convert GET to POST requests

Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #140:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/140#issuecomment-1672806226

   @Pearl1594 you probably don't want to do this as a default, we need to check if mgmt server logs API requests when things are POST-ed. You can probably add conditionals for new user-data related APIs. @hrak did you face issues when using the deploy VM API or other user-data related APIs?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org