You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/03 08:42:19 UTC

[GitHub] [doris] adonis0147 commented on a diff in pull request #11459: [enhancement](Nereids)set default join type to CROSS_JOIN

adonis0147 commented on code in PR #11459:
URL: https://github.com/apache/doris/pull/11459#discussion_r936397601


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -584,7 +584,7 @@ public LogicalPlan visitFromClause(FromClauseContext ctx) {
                 LogicalPlan right = plan(relation.relationPrimary());
                 left = left == null

Review Comment:
   Add parentheses to improve readability.
   
   ```suggestion
                   left = (left == null)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org