[GitHub] [iceberg] rdblue commented on a diff in pull request #5957: Python: Cleanup inconsistency in OAuth responses

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5957:
URL: https://github.com/apache/iceberg/pull/5957#discussion_r992778219


##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -97,7 +98,9 @@ def load_catalog(name: str, **properties: str | None) -> Catalog:
         if inferred_catalog_type := infer_catalog_type(conf):
             catalog_type = inferred_catalog_type
         else:
-            raise ValueError(f"Invalid configuration. Could not determine the catalog type: {properties}")
+            raise ValueError(
+                f"URI missing, please provide using --uri, the config or environment variable PYICEBERG_CATALOG__{name.upper()}__URI"

Review Comment:
   I don't think this is necessarily true. Isn't the old error message more accurate?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org