You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nlpcraft.apache.org by ar...@apache.org on 2021/12/13 07:35:25 UTC
[incubator-nlpcraft] branch master updated: Added lifecycle support back.
This is an automated email from the ASF dual-hosted git repository.
aradzinski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nlpcraft.git
The following commit(s) were added to refs/heads/master by this push:
new 95228d0 Added lifecycle support back.
95228d0 is described below
commit 95228d0787021a9db7bc3189ecb5feaee7721f40
Author: Aaron Radzinski <ar...@datalingvo.com>
AuthorDate: Sun Dec 12 23:35:18 2021 -0800
Added lifecycle support back.
---
.../main/scala/org/apache/nlpcraft/NCEntityEnricher.java | 2 +-
.../main/scala/org/apache/nlpcraft/NCEntityParser.java | 2 +-
.../nlpcraft/{NCTokenParser.java => NCLIfecycle.java} | 15 +++++++--------
.../src/main/scala/org/apache/nlpcraft/NCModelClient.java | 12 +++++++++++-
.../main/scala/org/apache/nlpcraft/NCTokenEnricher.java | 2 +-
.../src/main/scala/org/apache/nlpcraft/NCTokenParser.java | 2 +-
6 files changed, 22 insertions(+), 13 deletions(-)
diff --git a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCEntityEnricher.java b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCEntityEnricher.java
index 943168d..5fff3b8 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCEntityEnricher.java
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCEntityEnricher.java
@@ -22,7 +22,7 @@ import java.util.*;
/**
*
*/
-public interface NCEntityEnricher {
+public interface NCEntityEnricher extends NCLIfecycle {
/**
*
* @param req
diff --git a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCEntityParser.java b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCEntityParser.java
index 46f1b55..c66f3c5 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCEntityParser.java
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCEntityParser.java
@@ -22,7 +22,7 @@ import java.util.List;
/**
*
*/
-public interface NCEntityParser {
+public interface NCEntityParser extends NCLIfecycle {
/**
*
* @param req
diff --git a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCTokenParser.java b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCLIfecycle.java
similarity index 83%
copy from nlpcraft/src/main/scala/org/apache/nlpcraft/NCTokenParser.java
copy to nlpcraft/src/main/scala/org/apache/nlpcraft/NCLIfecycle.java
index c52cc08..b55df55 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCTokenParser.java
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCLIfecycle.java
@@ -17,18 +17,17 @@
package org.apache.nlpcraft;
-import java.util.List;
-
/**
*
*/
-public interface NCTokenParser {
+public interface NCLIfecycle {
+ /**
+ *
+ */
+ default void start() {}
+
/**
*
- * @param req
- * @return
- * @throws
- * @throws NCException
*/
- List<NCToken> parse(NCRequest req);
+ default void stop() {}
}
diff --git a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCModelClient.java b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCModelClient.java
index 83b73ec..9135bbd 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCModelClient.java
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCModelClient.java
@@ -23,7 +23,7 @@ import java.util.concurrent.*;
/**
*
*/
-public class NCModelClient {
+public class NCModelClient implements NCLIfecycle {
private NCModel mdl;
/**
@@ -34,6 +34,16 @@ public class NCModelClient {
this.mdl = mdl;
}
+ @Override
+ public void start() {
+ // TODO
+ }
+
+ @Override
+ public void stop() {
+ // TODO
+ }
+
/**
*
* @param txt
diff --git a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCTokenEnricher.java b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCTokenEnricher.java
index 31e6d09..5837109 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCTokenEnricher.java
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCTokenEnricher.java
@@ -22,7 +22,7 @@ import java.util.*;
/**
*
*/
-public interface NCTokenEnricher {
+public interface NCTokenEnricher extends NCLIfecycle {
/**
*
* @param req
diff --git a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCTokenParser.java b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCTokenParser.java
index c52cc08..236c3a7 100644
--- a/nlpcraft/src/main/scala/org/apache/nlpcraft/NCTokenParser.java
+++ b/nlpcraft/src/main/scala/org/apache/nlpcraft/NCTokenParser.java
@@ -22,7 +22,7 @@ import java.util.List;
/**
*
*/
-public interface NCTokenParser {
+public interface NCTokenParser extends NCLIfecycle {
/**
*
* @param req