You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by nareshpr <gi...@git.apache.org> on 2015/04/08 09:18:16 UTC
[GitHub] spark pull request: [SPARK-6762][Streaming]Moved stream close into...
GitHub user nareshpr opened a pull request:
https://github.com/apache/spark/pull/5413
[SPARK-6762][Streaming]Moved stream close into finally block
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nareshpr/spark handle_file_close
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5413.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5413
----
commit cea37a341bcd28a728317e7c06775d84a1cca1ed
Author: nareshpr <pr...@gmail.com>
Date: 2015-04-08T06:18:18Z
vmoved stream close into finally block
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6762][Streaming]Moved stream close into...
Posted by nareshpr <gi...@git.apache.org>.
Github user nareshpr commented on the pull request:
https://github.com/apache/spark/pull/5413#issuecomment-90857729
Ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6762][Streaming]Moved stream close into...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5413#issuecomment-90828804
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6762][Streaming]Moved stream close into...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5413#issuecomment-90856170
@nareshpr , @zhichao-li has a fix for this issue he created at https://github.com/apache/spark/pull/5407 and it looks more complete. Would you mind closing this PR but then reviewing the other PR and suggest any changes from yours that you think should be added?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6762][Streaming]Moved stream close into...
Posted by nareshpr <gi...@git.apache.org>.
Github user nareshpr closed the pull request at:
https://github.com/apache/spark/pull/5413
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org