You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/05/30 08:14:08 UTC
[GitHub] [libcloud] Kami opened a new pull request, #1701: Update EC2 driver so it doesn't throw when "list_image()" method is called and an image doesn't contain creation date attribute
Kami opened a new pull request, #1701:
URL: https://github.com/apache/libcloud/pull/1701
This pull request contains a small fix for the EC2 driver - in some cases when using ``list_image()`` method, returned image doesn't contain ``creationDate`` attribute or it's empty.
In such case, the code would previously throw. This PR updates the code to allow empty ``creationDate`` date - now if an empty attribute is encountered, we simply set that ``Image`` extra attribute value to ``None``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami merged pull request #1701: Update EC2 driver so it doesn't throw when "list_image()" method is called and an image doesn't contain creation date attribute
Posted by GitBox <gi...@apache.org>.
Kami merged PR #1701:
URL: https://github.com/apache/libcloud/pull/1701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] codecov-commenter commented on pull request #1701: Update EC2 driver so it doesn't throw when "list_image()" method is called and an image doesn't contain creation date attribute
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1701:
URL: https://github.com/apache/libcloud/pull/1701#issuecomment-1140854924
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1701?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1701](https://codecov.io/gh/apache/libcloud/pull/1701?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9623799) into [trunk](https://codecov.io/gh/apache/libcloud/commit/5eef11e2d2a157557934f5667daaf5e6065ab628?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5eef11e) will **increase** coverage by `0.00%`.
> The diff coverage is `87.50%`.
> :exclamation: Current head 9623799 differs from pull request most recent head 9206a9a. Consider uploading reports for the commit 9206a9a to get more accurate results
[](https://codecov.io/gh/apache/libcloud/pull/1701?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## trunk #1701 +/- ##
=======================================
Coverage 83.29% 83.29%
=======================================
Files 400 400
Lines 87755 87759 +4
Branches 9328 9329 +1
=======================================
+ Hits 73092 73096 +4
Misses 11485 11485
Partials 3178 3178
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1701?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libcloud/utils/iso8601.py](https://codecov.io/gh/apache/libcloud/pull/1701/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdXRpbHMvaXNvODYwMS5weQ==) | `84.00% <80.00%> (+1.39%)` | :arrow_up: |
| [libcloud/compute/drivers/ec2.py](https://codecov.io/gh/apache/libcloud/pull/1701/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL2VjMi5weQ==) | `75.49% <100.00%> (ø)` | |
| [libcloud/test/compute/test\_ec2.py](https://codecov.io/gh/apache/libcloud/pull/1701/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3RfZWMyLnB5) | `97.91% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1701?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1701?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5eef11e...9206a9a](https://codecov.io/gh/apache/libcloud/pull/1701?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org