Re: [PR] refactor(hubble): enhance maven front plugin [incubator-hugegraph-toolchain]

["liuxiaocs7 (via GitHub)" <gi...@apache.org>]

liuxiaocs7 commented on code in PR #568:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/568#discussion_r1444352362


##########
hugegraph-hubble/hubble-dist/pom.xml:
##########
@@ -73,21 +76,24 @@
                 <version>1.14.2</version>
 
                 <configuration>
-                    <installDirectory>target</installDirectory>
-                    <workingDirectory>../hubble-fe</workingDirectory>
+                    <installDirectory>${hubble-fe.dir}</installDirectory>
+                    <workingDirectory>${hubble-fe.dir}</workingDirectory>
                 </configuration>
 
                 <executions>
                     <execution>
                         <id>install node and yarn</id>
                         <goals>
                             <goal>install-node-and-yarn</goal>
-                            <goal>install-node-and-npm</goal>
                         </goals>
                         <configuration>
-                            <nodeVersion>v16.16.0</nodeVersion>
-                            <npmVersion>8.19.1</npmVersion>
-                            <yarnVersion>v1.22.15</yarnVersion>
+                            <nodeVersion>${build.node.version}</nodeVersion>
+                            <npmVersion>${build.npm.version}</npmVersion>
+                            <yarnVersion>${build.yarn.version}</yarnVersion>
+                            <nodeDownloadRoot>https://npm.taobao.org/mirrors/node/</nodeDownloadRoot>
+                            <npmDownloadRoot>https://registry.npmmirror.com/npm/-/</npmDownloadRoot>
+                            <yarnDownloadRoot>https://repo.huaweicloud.com/yarn/</yarnDownloadRoot>

Review Comment:
   seems not now, The download address is automatically spliced based on url and version
   
   ```
   prefix/{version}/yarn-{version}.tar.gz
   ```
   
   Optional download address：
   
   ```
   https://repo.huaweicloud.com/yarn/v1.22.21/yarn-v1.22.21.tar.gz        √
   
   https://registry.npmmirror.com/yarn/-/yarn-1.22.21.tgz                 ×
   ```
   
   but we can not download file from this url below.
   
   ```
   https://registry.npmmirror.com/yarn/v1.22.21/yarn-v1.22.21.tar.gz
   ```
   
   ref: https://github.com/eirslett/frontend-maven-plugin/issues/601



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org