You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Jeff Young (Created) (JIRA)" <ji...@apache.org> on 2012/03/20 15:41:46 UTC
[jira] [Created] (SLING-2441) AuthenticationInfo.put() throws if
method is null
AuthenticationInfo.put() throws if method is null
-------------------------------------------------
Key: SLING-2441
URL: https://issues.apache.org/jira/browse/SLING-2441
Project: Sling
Issue Type: Bug
Components: Authentication
Affects Versions: Auth Core 1.0.6
Reporter: Jeff Young
Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE.
(This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2441) AuthenticationInfo.put() throws if
method is null
Posted by "Justin Edelson (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson reassigned SLING-2441:
-------------------------------------
Assignee: Justin Edelson
> AuthenticationInfo.put() throws if method is null
> -------------------------------------------------
>
> Key: SLING-2441
> URL: https://issues.apache.org/jira/browse/SLING-2441
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Jeff Young
> Assignee: Justin Edelson
> Labels: newbie, patch
> Fix For: Auth Core 1.1.0
>
> Attachments: auth_info_put.patch
>
>
> Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE.
> (This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2441) AuthenticationInfo.put() throws if
method is null
Posted by "Jeff Young (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Young updated SLING-2441:
------------------------------
Attachment: auth_info_put.patch
> AuthenticationInfo.put() throws if method is null
> -------------------------------------------------
>
> Key: SLING-2441
> URL: https://issues.apache.org/jira/browse/SLING-2441
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Jeff Young
> Labels: newbie, patch
> Attachments: auth_info_put.patch
>
>
> Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE.
> (This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2441) AuthenticationInfo.put() throws if
method is null
Posted by "Justin Edelson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240480#comment-13240480 ]
Justin Edelson commented on SLING-2441:
---------------------------------------
Perhaps I'm missing something really obvious, but why would this change require a recompilation? There's no signature change.
> AuthenticationInfo.put() throws if method is null
> -------------------------------------------------
>
> Key: SLING-2441
> URL: https://issues.apache.org/jira/browse/SLING-2441
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Jeff Young
> Assignee: Justin Edelson
> Labels: newbie, patch
> Fix For: Auth Core 1.1.0
>
> Attachments: auth_info_put.patch
>
>
> Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE.
> (This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2441) AuthenticationInfo.put() throws if
method is null
Posted by "Justin Edelson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240495#comment-13240495 ]
Justin Edelson commented on SLING-2441:
---------------------------------------
Ah, fair enough. Not really a compilation change, but a mainfest update. But I see your point.
But do you agree that if we make this change, the exported package version has to change?
> AuthenticationInfo.put() throws if method is null
> -------------------------------------------------
>
> Key: SLING-2441
> URL: https://issues.apache.org/jira/browse/SLING-2441
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Jeff Young
> Assignee: Justin Edelson
> Labels: newbie, patch
> Fix For: Auth Core 1.1.0
>
> Attachments: auth_info_put.patch
>
>
> Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE.
> (This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2441) AuthenticationInfo.put() throws if
method is null
Posted by "Jeff Young (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240489#comment-13240489 ]
Jeff Young commented on SLING-2441:
-----------------------------------
If we stick with the old behaviour than someone will need to fix AuthenticationInfoPostProcessorBridge.
> AuthenticationInfo.put() throws if method is null
> -------------------------------------------------
>
> Key: SLING-2441
> URL: https://issues.apache.org/jira/browse/SLING-2441
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Jeff Young
> Assignee: Justin Edelson
> Labels: newbie, patch
> Fix For: Auth Core 1.1.0
>
> Attachments: auth_info_put.patch
>
>
> Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE.
> (This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (SLING-2441) AuthenticationInfo.put() throws if
method is null
Posted by "Felix Meschberger (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reopened SLING-2441:
--------------------------------------
Sorry to reopen.
Keeping this fix, will require all down stream implementations of the SPI interfaces
to be recompiled for no really obvious reason.
One part of the problem, is that we have to adapt the documentation, that we accept
the authentication type to be null on object creation.
But for subsequent update, I think we should stick with the old behaviour of not accepting null.
> AuthenticationInfo.put() throws if method is null
> -------------------------------------------------
>
> Key: SLING-2441
> URL: https://issues.apache.org/jira/browse/SLING-2441
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Jeff Young
> Assignee: Justin Edelson
> Labels: newbie, patch
> Fix For: Auth Core 1.1.0
>
> Attachments: auth_info_put.patch
>
>
> Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE.
> (This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2441) AuthenticationInfo.put() throws if
method is null
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290125#comment-13290125 ]
Felix Meschberger commented on SLING-2441:
------------------------------------------
> But do you agree that if we make this change, the exported package version has to change?
Yes, but on second thought, I think I am also opposing the change per se.
While it is probably (internally to the Sling Auth Core bundle ??) ok to create an AuthenticationInfo with null AUTH_TYPE, I would think that setting a null AUTH_TYPE with put is wrong (in fact, probably put should be disallowed completely for the AUTH_TYPE property).
So, I think we should really revert this complete change.
> AuthenticationInfo.put() throws if method is null
> -------------------------------------------------
>
> Key: SLING-2441
> URL: https://issues.apache.org/jira/browse/SLING-2441
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Jeff Young
> Assignee: Justin Edelson
> Labels: newbie, patch
> Fix For: Auth Core 1.1.0
>
> Attachments: auth_info_put.patch
>
>
> Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE.
> (This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2441) AuthenticationInfo.put() throws if
method is null
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290131#comment-13290131 ]
Justin Edelson commented on SLING-2441:
---------------------------------------
OK. I'll revert and change the status of this issue.
> AuthenticationInfo.put() throws if method is null
> -------------------------------------------------
>
> Key: SLING-2441
> URL: https://issues.apache.org/jira/browse/SLING-2441
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Jeff Young
> Assignee: Justin Edelson
> Labels: newbie, patch
> Fix For: Auth Core 1.1.0
>
> Attachments: auth_info_put.patch
>
>
> Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE.
> (This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2441) AuthenticationInfo.put() throws if
method is null
Posted by "Felix Meschberger (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240486#comment-13240486 ]
Felix Meschberger commented on SLING-2441:
------------------------------------------
Right, but you updated the exported version from 1.0.4 to 1.1.0 which constitutes breaking backwards compatibility for API implementors according to semantic versioning.
> AuthenticationInfo.put() throws if method is null
> -------------------------------------------------
>
> Key: SLING-2441
> URL: https://issues.apache.org/jira/browse/SLING-2441
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Jeff Young
> Assignee: Justin Edelson
> Labels: newbie, patch
> Fix For: Auth Core 1.1.0
>
> Attachments: auth_info_put.patch
>
>
> Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE.
> (This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2441) AuthenticationInfo.put() throws if
method is null
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson resolved SLING-2441.
-----------------------------------
Resolution: Won't Fix
reverted change in r1346876
> AuthenticationInfo.put() throws if method is null
> -------------------------------------------------
>
> Key: SLING-2441
> URL: https://issues.apache.org/jira/browse/SLING-2441
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Jeff Young
> Assignee: Justin Edelson
> Labels: newbie, patch
> Fix For: Auth Core 1.1.0
>
> Attachments: auth_info_put.patch
>
>
> Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE.
> (This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2441) AuthenticationInfo.put() throws if
method is null
Posted by "Justin Edelson (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson resolved SLING-2441.
-----------------------------------
Resolution: Fixed
patch applied in r1304352. Thanks!
> AuthenticationInfo.put() throws if method is null
> -------------------------------------------------
>
> Key: SLING-2441
> URL: https://issues.apache.org/jira/browse/SLING-2441
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Jeff Young
> Assignee: Justin Edelson
> Labels: newbie, patch
> Fix For: Auth Core 1.1.0
>
> Attachments: auth_info_put.patch
>
>
> Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE.
> (This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2441) AuthenticationInfo.put() throws if
method is null
Posted by "Justin Edelson (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson updated SLING-2441:
----------------------------------
Fix Version/s: Auth Core 1.1.0
> AuthenticationInfo.put() throws if method is null
> -------------------------------------------------
>
> Key: SLING-2441
> URL: https://issues.apache.org/jira/browse/SLING-2441
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Jeff Young
> Assignee: Justin Edelson
> Labels: newbie, patch
> Fix For: Auth Core 1.1.0
>
> Attachments: auth_info_put.patch
>
>
> Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE.
> (This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2441) AuthenticationInfo.put() throws if
method is null
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson updated SLING-2441:
----------------------------------
Fix Version/s: (was: Auth Core 1.1.0)
> AuthenticationInfo.put() throws if method is null
> -------------------------------------------------
>
> Key: SLING-2441
> URL: https://issues.apache.org/jira/browse/SLING-2441
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Jeff Young
> Assignee: Justin Edelson
> Labels: newbie, patch
> Attachments: auth_info_put.patch
>
>
> Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE. The put() method, however, throws if passed a null AUTH_TYPE.
> (This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira