You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dzhigimont (via GitHub)" <gi...@apache.org> on 2023/03/10 15:44:17 UTC
[GitHub] [spark] dzhigimont opened a new pull request, #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
dzhigimont opened a new pull request, #40370:
URL: https://github.com/apache/spark/pull/40370
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add `inclusive` parameter for (DataFrame|Series).between_time to support the pandas 2.0.0
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
When pandas 2.0.0 is released, we should match the behavior in pandas API on Spark.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
yes, the API changes
Before:
` (DataFrame|Series).between_time(start_time, end_time, include_start, include_end, axis)`
After:
` (DataFrame|Series).between_time(start_time, end_time, inclusive, axis)`
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Unit tests were updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dzhigimont commented on a diff in pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "dzhigimont (via GitHub)" <gi...@apache.org>.
dzhigimont commented on code in PR #40370:
URL: https://github.com/apache/spark/pull/40370#discussion_r1286803440
##########
python/docs/source/migration_guide/pyspark_upgrade.rst:
##########
@@ -28,6 +28,7 @@ Upgrading from PySpark 3.5 to 4.0
* In Spark 4.0, ``Series.append`` has been removed from pandas API on Spark, use ``ps.concat`` instead.
* In Spark 4.0, ``DataFrame.mad`` has been removed from pandas API on Spark.
* In Spark 4.0, ``Series.mad`` has been removed from pandas API on Spark.
+* In Spark 4.0, ``Series.between_time`` and ``DataFrame.between_time`` in Pandas on Spark have a new parameter ``inclusive`` instead of two old parameters ``include_start`` and ``include_end``.
Review Comment:
Applied
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #40370:
URL: https://github.com/apache/spark/pull/40370#issuecomment-1524450947
Change itself looks pretty good to me, once the CI is passed after the [initial pandas 2.0 support](https://github.com/apache/spark/pull/40658) completing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40370:
URL: https://github.com/apache/spark/pull/40370#issuecomment-1467721718
cc @itholic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #40370:
URL: https://github.com/apache/spark/pull/40370#discussion_r1286495087
##########
python/pyspark/pandas/tests/frame/test_reindexing.py:
##########
@@ -854,7 +879,8 @@ def test_sample(self):
class FrameReidexingTests(FrameReindexingMixin, ComparisonTestBase, SQLTestUtils):
- pass
+ def test_between_time(self):
+ super().test_between_time()
Review Comment:
> My bad, committed that accidentally, it was used for running only that one on local env
No worries, it also sometimes happen to me :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40370:
URL: https://github.com/apache/spark/pull/40370#issuecomment-1671159880
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40370:
URL: https://github.com/apache/spark/pull/40370#issuecomment-1671163957
@dzhigimont do you have a JIRA id? I should assign it to you at https://issues.apache.org/jira/browse/SPARK-42620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dzhigimont commented on pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "dzhigimont (via GitHub)" <gi...@apache.org>.
dzhigimont commented on PR #40370:
URL: https://github.com/apache/spark/pull/40370#issuecomment-1673185816
> https://selfserve.apache.org/jira-account.html
I've created an account with **dzhigimont** an user login
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #40370:
URL: https://github.com/apache/spark/pull/40370#discussion_r1286496031
##########
python/docs/source/migration_guide/pyspark_upgrade.rst:
##########
@@ -28,6 +28,7 @@ Upgrading from PySpark 3.5 to 4.0
* In Spark 4.0, ``Series.append`` has been removed from pandas API on Spark, use ``ps.concat`` instead.
* In Spark 4.0, ``DataFrame.mad`` has been removed from pandas API on Spark.
* In Spark 4.0, ``Series.mad`` has been removed from pandas API on Spark.
+* In Spark 4.0, ``Series.between_time`` and ``DataFrame.between_time`` in Pandas on Spark have a new parameter ``inclusive`` instead of two old parameters ``include_start`` and ``include_end``.
Review Comment:
```suggestion
* In Spark 4.0, ``include_start`` and ``include_end`` parameter from ``DataFrame.between_time`` have been removed from pandas API on Spark, use ``inclusive`` instead.
* In Spark 4.0, ``include_start`` and ``include_end`` parameter from ``Series.between_time`` have been removed from pandas API on Spark, use ``inclusive`` instead.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40370:
URL: https://github.com/apache/spark/pull/40370#issuecomment-1672430688
https://selfserve.apache.org/jira-account.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #40370:
URL: https://github.com/apache/spark/pull/40370#issuecomment-1672465284
Thanks @dzhigimont for working on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dzhigimont commented on a diff in pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "dzhigimont (via GitHub)" <gi...@apache.org>.
dzhigimont commented on code in PR #40370:
URL: https://github.com/apache/spark/pull/40370#discussion_r1175552369
##########
python/pyspark/pandas/frame.py:
##########
@@ -3582,14 +3571,18 @@ def between_time(
if not isinstance(self.index, ps.DatetimeIndex):
raise TypeError("Index must be DatetimeIndex")
+ if inclusive not in ["left", "right", "both", "neither"]:
+ msg = "Inclusive has to be either 'both', 'neither', 'left' or 'right'"
+ raise ValueError(msg)
Review Comment:
Changed to PySparkValueError and the new error_class has been added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dzhigimont commented on pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "dzhigimont (via GitHub)" <gi...@apache.org>.
dzhigimont commented on PR #40370:
URL: https://github.com/apache/spark/pull/40370#issuecomment-1671170693
@HyukjinKwon Unfortunately I don't have it, how can create it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #40370:
URL: https://github.com/apache/spark/pull/40370#issuecomment-1663773331
We're ready for supporting pandas 2.0.0. @dzhigimont could you revisit this PR when you find some time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #40370:
URL: https://github.com/apache/spark/pull/40370#discussion_r1174748478
##########
python/pyspark/pandas/frame.py:
##########
@@ -3582,14 +3571,18 @@ def between_time(
if not isinstance(self.index, ps.DatetimeIndex):
raise TypeError("Index must be DatetimeIndex")
+ if inclusive not in ["left", "right", "both", "neither"]:
+ msg = "Inclusive has to be either 'both', 'neither', 'left' or 'right'"
+ raise ValueError(msg)
Review Comment:
Can we use `PySparkValueError` and error classes?
##########
python/pyspark/pandas/frame.py:
##########
@@ -3519,16 +3516,8 @@ def between_time(
Initial time as a time filter limit.
end_time : datetime.time or str
End time as a time filter limit.
- include_start : bool, default True
- Whether the start time needs to be included in the result.
-
- .. deprecated:: 3.4.0
-
- include_end : bool, default True
- Whether the end time needs to be included in the result.
-
- .. deprecated:: 3.4.0
-
+ inclusive : {"both", "neither", "left", "right"}, default "both"
+ Include boundaries; whether to set each bound as closed or open.
Review Comment:
Let's add `versionadded`
##########
python/pyspark/pandas/series.py:
##########
@@ -6836,16 +6833,8 @@ def between_time(
Initial time as a time filter limit.
end_time : datetime.time or str
End time as a time filter limit.
- include_start : bool, default True
- Whether the start time needs to be included in the result.
-
- .. deprecated:: 3.4.0
-
- include_end : bool, default True
- Whether the end time needs to be included in the result.
-
- .. deprecated:: 3.4.0
-
+ inclusive : {"both", "neither", "left", "right"}, default "both"
+ Include boundaries; whether to set each bound as closed or open.
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #40370:
URL: https://github.com/apache/spark/pull/40370#discussion_r1285322684
##########
python/pyspark/pandas/tests/frame/test_reindexing.py:
##########
@@ -854,7 +879,8 @@ def test_sample(self):
class FrameReidexingTests(FrameReindexingMixin, ComparisonTestBase, SQLTestUtils):
- pass
+ def test_between_time(self):
+ super().test_between_time()
Review Comment:
We don't need to add a test here, since `FrameReidexingTests` already inherits `FrameReindexingMixin`.
##########
python/pyspark/pandas/series.py:
##########
@@ -6740,15 +6737,10 @@ def between_time(
Initial time as a time filter limit.
end_time : datetime.time or str
End time as a time filter limit.
- include_start : bool, default True
- Whether the start time needs to be included in the result.
+ inclusive : {"both", "neither", "left", "right"}, default "both"
+ Include boundaries; whether to set each bound as closed or open.
- .. deprecated:: 3.4.0
-
- include_end : bool, default True
- Whether the end time needs to be included in the result.
-
- .. deprecated:: 3.4.0
+ .. versionadded:: 3.5.0
Review Comment:
Should be 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
URL: https://github.com/apache/spark/pull/40370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dzhigimont commented on a diff in pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "dzhigimont (via GitHub)" <gi...@apache.org>.
dzhigimont commented on code in PR #40370:
URL: https://github.com/apache/spark/pull/40370#discussion_r1285551324
##########
python/pyspark/pandas/tests/frame/test_reindexing.py:
##########
@@ -854,7 +879,8 @@ def test_sample(self):
class FrameReidexingTests(FrameReindexingMixin, ComparisonTestBase, SQLTestUtils):
- pass
+ def test_between_time(self):
+ super().test_between_time()
Review Comment:
My bad, committed that accidentally, it was used for running only that one on local env
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dzhigimont commented on pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "dzhigimont (via GitHub)" <gi...@apache.org>.
dzhigimont commented on PR #40370:
URL: https://github.com/apache/spark/pull/40370#issuecomment-1668143968
> We should update the [migration guide](python/docs/source/migration_guide/pyspark_upgrade.rst) since it's breaking change.
>
> You can refer to https://github.com/apache/spark/pull/42268/files
The migration guide was updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dzhigimont commented on pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "dzhigimont (via GitHub)" <gi...@apache.org>.
dzhigimont commented on PR #40370:
URL: https://github.com/apache/spark/pull/40370#issuecomment-1464879868
Tests will not pass until Pandas 2.0.0 is released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dzhigimont commented on a diff in pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "dzhigimont (via GitHub)" <gi...@apache.org>.
dzhigimont commented on code in PR #40370:
URL: https://github.com/apache/spark/pull/40370#discussion_r1175551612
##########
python/pyspark/pandas/frame.py:
##########
@@ -3519,16 +3516,8 @@ def between_time(
Initial time as a time filter limit.
end_time : datetime.time or str
End time as a time filter limit.
- include_start : bool, default True
- Whether the start time needs to be included in the result.
-
- .. deprecated:: 3.4.0
-
- include_end : bool, default True
- Whether the end time needs to be included in the result.
-
- .. deprecated:: 3.4.0
-
+ inclusive : {"both", "neither", "left", "right"}, default "both"
+ Include boundaries; whether to set each bound as closed or open.
Review Comment:
Added
##########
python/pyspark/pandas/series.py:
##########
@@ -6836,16 +6833,8 @@ def between_time(
Initial time as a time filter limit.
end_time : datetime.time or str
End time as a time filter limit.
- include_start : bool, default True
- Whether the start time needs to be included in the result.
-
- .. deprecated:: 3.4.0
-
- include_end : bool, default True
- Whether the end time needs to be included in the result.
-
- .. deprecated:: 3.4.0
-
+ inclusive : {"both", "neither", "left", "right"}, default "both"
+ Include boundaries; whether to set each bound as closed or open.
Review Comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40370:
URL: https://github.com/apache/spark/pull/40370#issuecomment-1523825165
cc @itholic @zhengruifeng @xinrong-meng if you find some time to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dzhigimont commented on a diff in pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "dzhigimont (via GitHub)" <gi...@apache.org>.
dzhigimont commented on code in PR #40370:
URL: https://github.com/apache/spark/pull/40370#discussion_r1286084847
##########
python/pyspark/pandas/series.py:
##########
@@ -6740,15 +6737,10 @@ def between_time(
Initial time as a time filter limit.
end_time : datetime.time or str
End time as a time filter limit.
- include_start : bool, default True
- Whether the start time needs to be included in the result.
+ inclusive : {"both", "neither", "left", "right"}, default "both"
+ Include boundaries; whether to set each bound as closed or open.
- .. deprecated:: 3.4.0
-
- include_end : bool, default True
- Whether the end time needs to be included in the result.
-
- .. deprecated:: 3.4.0
+ .. versionadded:: 3.5.0
Review Comment:
Changed
##########
python/pyspark/pandas/tests/frame/test_reindexing.py:
##########
@@ -854,7 +879,8 @@ def test_sample(self):
class FrameReidexingTests(FrameReindexingMixin, ComparisonTestBase, SQLTestUtils):
- pass
+ def test_between_time(self):
+ super().test_between_time()
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dzhigimont commented on pull request #40370: [SPARK-42620][PS] Add `inclusive` parameter for (DataFrame|Series).between_time
Posted by "dzhigimont (via GitHub)" <gi...@apache.org>.
dzhigimont commented on PR #40370:
URL: https://github.com/apache/spark/pull/40370#issuecomment-1665699821
> We're ready for supporting pandas 2.0.0. @dzhigimont could you revisit this PR when you find some time?
Yes, I'm going to revisit my PRs in a couple of days
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org