You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/08/05 01:51:20 UTC
[GitHub] [pulsar] congbobo184 commented on a change in pull request #4877:
Add schema admin api get schema info with schema version
congbobo184 commented on a change in pull request #4877: Add schema admin api get schema info with schema version
URL: https://github.com/apache/pulsar/pull/4877#discussion_r310417935
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/SchemasResource.java
##########
@@ -461,11 +465,28 @@ public void getVersionBySchema(
}
private static GetSchemaResponse convertSchemaAndMetadataToGetSchemaResponse(SchemaAndMetadata schemaAndMetadata) {
+ String schemaData;
+ if (schemaAndMetadata.schema.getType() == SchemaType.KEY_VALUE) {
Review comment:
> Can you add test cases for this code path as well?
OK, I will add the tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services