[GitHub] [nifi] gresockj commented on pull request #5897: NIFI-9830: Use temp directory with post-rename during nar-unpacking

[GitBox <gi...@apache.org>]

gresockj commented on PR #5897:
URL: https://github.com/apache/nifi/pull/5897#issuecomment-1090600295

   > Can you provide some additional details on how the change improves performance?
   
   Sure -- in some use cases if the unpacking is interrupted, the working directory may be incomplete.  Previously, the only way around this was to delete the working directory prior to running stateless, regardless of whether the working directory was incomplete, in which case the NAR must be unpacked each time stateless starts.  This change allows us to be confident that the working directory is complete, and thus remove the unnecessary working directory cleanup before each stateless startup.
   
   While we could add some additional conditional code that only activates this mode in stateless, I don't think it has enough of a performance impact to warrant that complexity.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org