You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2020/04/15 13:22:23 UTC
[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15737
Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
......................................................................
IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
This commit eliminates an unnecessary hdfsDelete() call for INSERT-only
tables. For such tables we don't create a staging directory, hence there
is nothing to delete. It also eliminates a confusing log message about
the deletion of the staging directory (which did not even exist).
I also added a DCHECK to check that we don't even set the staging
directory for such tables.
Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
---
M be/src/runtime/coordinator.cc
M fe/src/main/java/org/apache/impala/service/Frontend.java
2 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/15737/1
--
To view, visit http://gerrit.cloudera.org:8080/15737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Gerrit-Change-Number: 15737
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15737 )
Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5689/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Gerrit-Change-Number: 15737
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 13:40:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15737
to look at the new patch set (#2).
Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
......................................................................
IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
This commit eliminates an unnecessary hdfsDelete() call for INSERT-only
tables. For such tables we don't create a staging directory, hence there
is nothing to delete. It also eliminates a confusing log message about
the deletion of the staging directory (which did not even exist).
I also added a DCHECK to check that we don't even set the staging
directory for such tables.
Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
---
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M fe/src/main/java/org/apache/impala/service/Frontend.java
3 files changed, 15 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/15737/2
--
To view, visit http://gerrit.cloudera.org:8080/15737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Gerrit-Change-Number: 15737
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15737 )
Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Gerrit-Change-Number: 15737
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 13:39:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15737 )
Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Gerrit-Change-Number: 15737
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 18:03:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15737 )
Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Gerrit-Change-Number: 15737
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 13:01:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15737 )
Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15737/1/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:
http://gerrit.cloudera.org:8080/#/c/15737/1/fe/src/main/java/org/apache/impala/service/Frontend.java@1703
PS1, Line 1703: finalizeParams.setStaging_dir(
: hdfsTable.getHdfsBaseDir() + "/_impala_insert_staging");
> It doesn't control where Impala puts the files, but it controls which direc
My idea here is not to fix it, but to remove this member from thrift, as it falsely creates the illusion that this can be controlled from Frontend. If we make this actually configurable from a flag/query option in the future, this member still won't make sense, as flags/query options can be easily accessed from backend.
I don't mind if you don't remove this now, but a TODO could be useful here to warn people that some parts of the backend do not respect this setting.
--
To view, visit http://gerrit.cloudera.org:8080/15737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Gerrit-Change-Number: 15737
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Apr 2020 13:28:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15737
to look at the new patch set (#3).
Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
......................................................................
IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
This commit eliminates an unnecessary hdfsDelete() call for INSERT-only
tables. For such tables we don't create a staging directory, hence there
is nothing to delete. It also eliminates a confusing log message about
the deletion of the staging directory (which did not even exist).
I also added a DCHECK to check that we don't even set the staging
directory for such tables.
Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
---
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M fe/src/main/java/org/apache/impala/service/Frontend.java
3 files changed, 19 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/15737/3
--
To view, visit http://gerrit.cloudera.org:8080/15737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Gerrit-Change-Number: 15737
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15737 )
Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
......................................................................
IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
This commit eliminates an unnecessary hdfsDelete() call for INSERT-only
tables. For such tables we don't create a staging directory, hence there
is nothing to delete. It also eliminates a confusing log message about
the deletion of the staging directory (which did not even exist).
I also added a DCHECK to check that we don't even set the staging
directory for such tables.
Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Reviewed-on: http://gerrit.cloudera.org:8080/15737
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M fe/src/main/java/org/apache/impala/service/Frontend.java
3 files changed, 19 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Gerrit-Change-Number: 15737
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15737 )
Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15737/1/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:
http://gerrit.cloudera.org:8080/#/c/15737/1/be/src/runtime/coordinator.cc@760
PS1, Line 760: return return_status;
> I am slightly worried about the early delete in a finalize function, as som
I agree, done.
http://gerrit.cloudera.org:8080/#/c/15737/1/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:
http://gerrit.cloudera.org:8080/#/c/15737/1/fe/src/main/java/org/apache/impala/service/Frontend.java@1703
PS1, Line 1703: finalizeParams.setStaging_dir(
: hdfsTable.getHdfsBaseDir() + "/_impala_insert_staging");
> I wonder whether this thrift is meaningful at all - we have the same string
It doesn't control where Impala puts the files, but it controls which directory Impala deletes (in coordinator.cc).
The two being the same is only enforced by a test in test_insert_behaviour.py::test_insert_removes_staging_files.
I agree that it'd be nicer if both were controlled here, but I don't want to complicate this small fix.
--
To view, visit http://gerrit.cloudera.org:8080/15737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Gerrit-Change-Number: 15737
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Apr 2020 11:56:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15737 )
Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5829/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Gerrit-Change-Number: 15737
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Apr 2020 14:40:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15737 )
Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5807/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Gerrit-Change-Number: 15737
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 14:04:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15737 )
Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15737/1/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:
http://gerrit.cloudera.org:8080/#/c/15737/1/be/src/runtime/coordinator.cc@760
PS1, Line 760: return return_status;
I am slightly worried about the early delete in a finalize function, as someone may add some more logic to the end. My suggestion is to extract the end of the function to something like Status DeleteQueryLevelStagingDir and call it only for the non-transactional case.
http://gerrit.cloudera.org:8080/#/c/15737/1/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:
http://gerrit.cloudera.org:8080/#/c/15737/1/fe/src/main/java/org/apache/impala/service/Frontend.java@1703
PS1, Line 1703: finalizeParams.setStaging_dir(
: hdfsTable.getHdfsBaseDir() + "/_impala_insert_staging");
I wonder whether this thrift is meaningful at all - we have the same string baked in at https://github.com/apache/impala/blob/master/be/src/exec/hdfs-table-sink.cc#L125
--
To view, visit http://gerrit.cloudera.org:8080/15737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Gerrit-Change-Number: 15737
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 15:13:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15737 )
Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5810/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Gerrit-Change-Number: 15737
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Apr 2020 12:29:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15737 )
Change subject: IMPALA-9653: Impala shouldn't create/remove staging directory during transactional INSERTs
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15737/1/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:
http://gerrit.cloudera.org:8080/#/c/15737/1/fe/src/main/java/org/apache/impala/service/Frontend.java@1703
PS1, Line 1703: // TODO: Currently this flag only controls the removal of the query-level staging
: // directory. HdfsTableSink (that creates the staging dir) c
> My idea here is not to fix it, but to remove this member from thrift, as it
Added TODO comment.
--
To view, visit http://gerrit.cloudera.org:8080/15737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6a3a502fb3b3cfe7a68323d3b0145e5fb149460
Gerrit-Change-Number: 15737
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Apr 2020 13:59:15 +0000
Gerrit-HasComments: Yes