You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/12/19 21:25:01 UTC
[GitHub] [daffodil-vscode] mbeckerle commented on a diff in pull request #388: Run daffodil-debugger in CI.
mbeckerle commented on code in PR #388:
URL: https://github.com/apache/daffodil-vscode/pull/388#discussion_r1052646396
##########
build.sbt:
##########
@@ -78,7 +78,9 @@ lazy val core = project
name := "daffodil-debugger",
libraryDependencies ++= Seq(
"ch.qos.logback" % "logback-classic" % "1.2.11",
- "com.microsoft.java" % "com.microsoft.java.debug.core" % "0.38.0",
+ // scala-steward:off
Review Comment:
Can you also add a comment about why (java 8) this scala-steward off is here.
##########
src/tests/data/test.dfdl.xsd:
##########
@@ -16,15 +16,48 @@
limitations under the License.
-->
-<xs:schema xmlns:dfdl="http://www.ogf.org/dfdl/dfdl-1.0/"
- xmlns:xs="http://www.w3.org/2001/XMLSchema">
+<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema"
+ xmlns:dfdl="http://www.ogf.org/dfdl/dfdl-1.0/"
+ xmlns:daf="urn:ogf:dfdl:2013:imp:daffodil.apache.org:2018:ext"
+ xmlns:fn="http://www.w3.org/2005/xpath-functions">
- <xs:element name="name">
- <xs:simpleType>
- <xs:restriction base="xs:string">
- <xs:length value="25"/>
- </xs:restriction>
- </xs:simpleType>
- </xs:element>
+ <xs:annotation>
+ <xs:appinfo source="http://www.ogf.org/dfdl/">
+ <dfdl:defineFormat name="testFormat">
+ <dfdl:format alignmentUnits="bytes" lengthUnits="bits" representation="binary" binaryNumberRep="binary"
+ byteOrder="bigEndian" bitOrder="mostSignificantBitFirst" lengthKind="implicit" alignment="1" encodingErrorPolicy="replace"
+ binaryFloatRep="ieee" calendarPatternKind="implicit" documentFinalTerminatorCanBeMissing="yes"
+ emptyValueDelimiterPolicy="none" escapeSchemeRef="" fillByte="f" floating="no" ignoreCase="no"
+ initiatedContent="no" initiator="" leadingSkip="0" separator="" separatorSuppressionPolicy="anyEmpty"
+ textStandardZeroRep="0" textStandardInfinityRep="Inf" textStandardExponentRep="E"
+ textStandardNaNRep="NaN" textNumberPattern="#,##0.###;-#,##0.###" textNumberRounding="explicit"
+ textNumberRoundingMode="roundUnnecessary" textNumberRoundingIncrement="0" textStandardGroupingSeparator=","
+ separatorPosition="infix" sequenceKind="ordered" terminator="" textBidi="no" textNumberCheckPolicy="strict"
+ textNumberRep="standard" textPadKind="none" textStandardBase="10" textTrimKind="none" trailingSkip="0" truncateSpecifiedLengthString="no"
+ utf16Width="fixed" encoding="US-ASCII" nilKind="literalValue" nilValueDelimiterPolicy="none" occursCountKind="parsed"
+ textOutputMinLength="0" />
+ </dfdl:defineFormat>
+ <dfdl:format ref="testFormat"/>
+ </xs:appinfo>
+ </xs:annotation>
+
+ <xs:element name="element">
+ <xs:complexType>
+ <xs:sequence>
+ <xs:sequence>
+ <xs:annotation>
+ <xs:appinfo source="http://www.ogf.org/dfdl/">
+ </xs:appinfo>
+ </xs:annotation>
+ </xs:sequence>
+ <xs:sequence dfdl:hiddenGroupRef="hiddenGroup" />
+ </xs:sequence>
+ </xs:complexType>
+ </xs:element>
+
+ <xs:group name="hiddenGroup">
+ <xs:sequence>
Review Comment:
Add comment that this is intentionally an empty sequence (i..e., you didn't leave something out by accident.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org