You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by cmarcelk <gi...@git.apache.org> on 2012/10/19 18:17:14 UTC

incubator-cordova-mobile-spec pull request: Remove filter when fetching con...

GitHub user cmarcelk opened a pull request:

    https://github.com/apache/incubator-cordova-mobile-spec/pull/13

    Remove filter when fetching contacts

    See https://issues.apache.org/jira/browse/CB-1682
    
    This is a one-line change. I removed the filter when fetching contacts in the non-automatic test. Because there has been no indicator that filtering was happening before now, the results were misleading. The results should now be more in line with a user's expectations.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cmarcelk/incubator-cordova-mobile-spec CB-1682

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-cordova-mobile-spec/pull/13.patch

----
commit e6e840b2a53cd1bfa75bc49355abf82c52d0ebf6
Author: Marcel Kinard <cm...@gmail.com>
Date:   2012-10-19T09:11:31-07:00

    Remove filter when fetching contacts

----

incubator-cordova-coho pull request: improved docs and fixed testcases

Posted by Marcel Kinard <cm...@gmail.com>.
Sending this manually, as it appears it didn't get generated 
automatically. Thanks!



GitHub user cmarcelk opened a pull request:

     https://github.com/apache/incubator-cordova-coho/pull/2

     improved docs and fixed testcases

     See https://issues.apache.org/jira/browse/CB-1699
     
     - cleaned up some whitespaces in the coho script and output a message describing where the generated artifact is located.
     - added missing platform arg when invoking coho from tests.coffee script
     - commented out bin tests since coho does not generate bin content
     - fixed broken tests. They all pass now.
     - change from deprecated path.existsSync to fs.existsSync


You can merge this pull request into a Git repository by running:

     $ git pull https://github.com/cmarcelk/incubator-cordova-mobile-spec CB-1682

Alternatively you can review and apply these changes as the patch at:

     https://github.com/apache/incubator-cordova-mobile-spec/pull/13.patch

----
commit 6540ff3d9edee3e820e95b94fb89d49417390ccd
Author: Marcel Kinard <cm...@gmail.com>

----