[GitHub] [ignite-3] sashapolo opened a new pull request, #2408: IGNITE-19937 Remove BinaryRow#byteBuffer method

["sashapolo (via GitHub)" <gi...@apache.org>]

sashapolo opened a new pull request, #2408:
URL: https://github.com/apache/ignite-3/pull/2408

   https://issues.apache.org/jira/browse/IGNITE-19937
   
   Thank you for submitting the pull request.
   
   In order to streamline the review of the patch and ensure better code quality
   we ask both an author and a reviewer to check the following requirements:
   
   ### The Review Checklist
   - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also check the following list:  
   \- There is a single JIRA ticket related to the pull request.  
   \- The web-link to the pull request is attached to the JIRA ticket.  
   \- The JIRA ticket has the Patch Available state.  
   \- The description of the JIRA ticket explains WHAT and WHY was made and HOW.  
   \- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
   - [ ] **Design:** new code conforms with the design principles of the components it is added to.
   - [ ] **Patch quality:** patch cannot be split into a smaller pieces, its size is reasonable.
   - [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
   - [ ] **Tests code quality:** tests set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
   
   ### Notes
   - [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2408: IGNITE-19937 Remove BinaryRow#byteBuffer method

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #2408:
URL: https://github.com/apache/ignite-3/pull/2408#discussion_r1284363181


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/command/UpdateCommand.java:
##########
@@ -33,5 +34,13 @@ public interface UpdateCommand extends PartitionCommand {
     UUID rowUuid();
 
     @Nullable
-    ByteBuffer rowBuffer();
+    BinaryRowMessage rowMessage();
+
+    /** Returns the row to update. */

Review Comment:
   Add when it can be `null`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] tkalkirill merged pull request #2408: IGNITE-19937 Remove BinaryRow#byteBuffer method

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill merged PR #2408:
URL: https://github.com/apache/ignite-3/pull/2408


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org