You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "sxllwx (GitHub)" <gi...@apache.org> on 2020/03/13 09:31:07 UTC
[GitHub] [dubbo-go] sxllwx opened pull request #400: Add: kubernetes
registry and remote package unit test
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
Add unit test for kubernetes registry package and remote package.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/cfbd042e0e6666308e53f3a1d56a1e52dab3764d?src=pr&el=desc) will **decrease** coverage by `0.46%`.
> The diff coverage is `65.6%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
=========================================
- Coverage 67.46% 67% -0.47%
=========================================
Files 169 174 +5
Lines 8579 9261 +682
=========================================
+ Hits 5788 6205 +417
- Misses 2247 2448 +201
- Partials 544 608 +64
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `65.38% <100%> (+4.51%)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `57.37% <57.37%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `59.81% <59.81%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `72.34% <72.34%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `73.58% <73.58%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `52.54% <75%> (-0.03%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.04% <79.04%> (ø)` | |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `72.34% <85.71%> (-4.41%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0%> (-5.38%)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [cfbd042...a47cf73](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] flycash commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "flycash (GitHub)" <gi...@apache.org>.
Those codes may create multiple listeners. It may be a potential problem.
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/cfbd042e0e6666308e53f3a1d56a1e52dab3764d?src=pr&el=desc) will **decrease** coverage by `0.46%`.
> The diff coverage is `65.6%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
=========================================
- Coverage 67.46% 67% -0.47%
=========================================
Files 169 174 +5
Lines 8579 9261 +682
=========================================
+ Hits 5788 6205 +417
- Misses 2247 2448 +201
- Partials 544 608 +64
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `65.38% <100%> (+4.51%)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `57.37% <57.37%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `59.81% <59.81%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `72.34% <72.34%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `73.58% <73.58%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `52.54% <75%> (-0.03%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.04% <79.04%> (ø)` | |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `72.34% <85.71%> (-4.41%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0%> (-5.38%)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [cfbd042...d7a37ba](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "sxllwx (GitHub)" <gi...@apache.org>.
Yeah, i resolve in latest commit.
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/cfbd042e0e6666308e53f3a1d56a1e52dab3764d?src=pr&el=desc) will **decrease** coverage by `0.33%`.
> The diff coverage is `63.49%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
===========================================
- Coverage 67.46% 67.13% -0.34%
===========================================
Files 169 174 +5
Lines 8579 9262 +683
===========================================
+ Hits 5788 6218 +430
- Misses 2247 2443 +196
- Partials 544 601 +57
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `65.38% <100%> (+4.51%)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57% <57%> (ø)` | |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.03% <58.03%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `59.81% <59.81%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `72.34% <72.34%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `52.54% <75%> (-0.03%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80% <80%> (ø)` | |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `72.34% <85.71%> (-4.41%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [cfbd042...938d5ed](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "sxllwx (GitHub)" <gi...@apache.org>.
This change is also possible. But it is not recommended to use defer。
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
@sxllwx pls check the travis.
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683&el=desc) will **decrease** coverage by `1.10%`.
> The diff coverage is `48.13%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
===========================================
- Coverage 67.03% 65.93% -1.11%
===========================================
Files 161 167 +6
Lines 8331 9008 +677
===========================================
+ Hits 5585 5939 +354
- Misses 2222 2499 +277
- Partials 524 570 +46
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9mYWNhZGUuZ28=) | `0.00% <0.00%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `51.11% <51.11%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `60.56% <60.56%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `76.74% <76.74%> (ø)` | |
| [remoting/kubernetes/store.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9zdG9yZS5nbw==) | `78.50% <78.50%> (ø)` | |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100.00%> (ø)` | |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `93.06% <0.00%> (-2.81%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [a7ae33f...9af6c53](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `64.97%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
===========================================
- Coverage 67.03% 66.77% -0.27%
===========================================
Files 161 166 +5
Lines 8331 8999 +668
===========================================
+ Hits 5585 6009 +424
- Misses 2222 2410 +188
- Partials 524 580 +56
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57% <57%> (ø)` | |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.03% <58.03%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `73.58% <73.58%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `76.74% <76.74%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80% <80%> (ø)` | |
| [filter/filter\_impl/metrics\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL21ldHJpY3NfZmlsdGVyLmdv) | `86.36% <0%> (-13.64%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `64.24% <0%> (-4.85%)` | :arrow_down: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `93.06% <0%> (-2.81%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [a7ae33f...1ed3e91](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
pls split the params list into three lines
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `63.48%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
===========================================
+ Coverage 67.03% 67.09% +0.05%
===========================================
Files 161 167 +6
Lines 8331 9013 +682
===========================================
+ Hits 5585 6047 +462
- Misses 2222 2382 +160
- Partials 524 584 +60
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `57.18% <57.18%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.79% <57.79%> (ø)` | |
| [remoting/kubernetes/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9mYWNhZGUuZ28=) | `65.62% <65.62%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `70.42% <70.42%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `76.74% <76.74%> (ø)` | |
| [remoting/kubernetes/store.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9zdG9yZS5nbw==) | `78.09% <78.09%> (ø)` | |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `93.06% <0%> (-2.81%)` | :arrow_down: |
| [config/generic\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y29uZmlnL2dlbmVyaWNfc2VydmljZS5nbw==) | `0% <0%> (ø)` | :arrow_up: |
| ... and [13 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [a7ae33f...0886257](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **decrease** coverage by `0.18%`.
> The diff coverage is `63.07%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
===========================================
- Coverage 67.03% 66.85% -0.19%
===========================================
Files 161 167 +6
Lines 8331 9008 +677
===========================================
+ Hits 5585 6022 +437
- Misses 2222 2401 +179
- Partials 524 585 +61
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `56.19% <56.19%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.79% <57.79%> (ø)` | |
| [remoting/kubernetes/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9mYWNhZGUuZ28=) | `65.62% <65.62%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `70.42% <70.42%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `76.74% <76.74%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.09% <78.09%> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `35.29% <0%> (-29.42%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0%> (-10.15%)` | :arrow_down: |
| ... and [19 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [a7ae33f...83d3975](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
pls using t.Error instead of fmt.Println.
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/cfbd042e0e6666308e53f3a1d56a1e52dab3764d?src=pr&el=desc) will **decrease** coverage by `0.33%`.
> The diff coverage is `63.49%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
===========================================
- Coverage 67.46% 67.13% -0.34%
===========================================
Files 169 174 +5
Lines 8579 9262 +683
===========================================
+ Hits 5788 6218 +430
- Misses 2247 2443 +196
- Partials 544 601 +57
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `65.38% <100%> (+4.51%)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57% <57%> (ø)` | |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.03% <58.03%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `59.81% <59.81%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `72.34% <72.34%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `52.54% <75%> (-0.03%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80% <80%> (ø)` | |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `72.34% <85.71%> (-4.41%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [cfbd042...0769966](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `64.43%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
=========================================
- Coverage 67.03% 67% -0.04%
=========================================
Files 161 167 +6
Lines 8331 9004 +673
=========================================
+ Hits 5585 6033 +448
- Misses 2222 2388 +166
- Partials 524 583 +59
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `57.46% <57.46%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `61.16% <61.16%> (ø)` | |
| [remoting/kubernetes/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9mYWNhZGUuZ28=) | `65.62% <65.62%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `70.42% <70.42%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `76.74% <76.74%> (ø)` | |
| [remoting/kubernetes/store.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9zdG9yZS5nbw==) | `78.5% <78.5%> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `35.29% <0%> (-29.42%)` | :arrow_down: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `93.06% <0%> (-2.81%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [a7ae33f...dfa8267](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "sxllwx (GitHub)" <gi...@apache.org>.
I think it is needed。
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "zouyx (GitHub)" <gi...@apache.org>.
what about use sync once to refactor ?
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `65.68%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
===========================================
- Coverage 67.03% 67.01% -0.03%
===========================================
Files 161 167 +6
Lines 8331 9010 +679
===========================================
+ Hits 5585 6038 +453
- Misses 2222 2390 +168
- Partials 524 582 +58
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `57.81% <57.81%> (ø)` | |
| [remoting/kubernetes/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9mYWNhZGUuZ28=) | `65.62% <65.62%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `66.99% <66.99%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `70.42% <70.42%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `76.74% <76.74%> (ø)` | |
| [remoting/kubernetes/store.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9zdG9yZS5nbw==) | `80.55% <80.55%> (ø)` | |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `93.06% <0%> (-2.81%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [a7ae33f...d776f8e](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
LGTM
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **increase** coverage by `0.15%`.
> The diff coverage is `64.51%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
===========================================
+ Coverage 67.03% 67.19% +0.15%
===========================================
Files 161 167 +6
Lines 8331 9013 +682
===========================================
+ Hits 5585 6056 +471
- Misses 2222 2376 +154
- Partials 524 581 +57
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `57.81% <57.81%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `60.55% <60.55%> (ø)` | |
| [remoting/kubernetes/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9mYWNhZGUuZ28=) | `65.62% <65.62%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `70.42% <70.42%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `76.74% <76.74%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80% <80%> (ø)` | |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `93.06% <0%> (-2.81%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0%> (-1.22%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [a7ae33f...7b13b44](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "sxllwx (GitHub)" <gi...@apache.org>.
Yes, I already fix it.
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "sxllwx (GitHub)" <gi...@apache.org>.
Yes, i already resolve it.
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "sxllwx (GitHub)" <gi...@apache.org>.
Yes, I already fix it.
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
change the lock type from Mutex lock to RW mutex lock.
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/cfbd042e0e6666308e53f3a1d56a1e52dab3764d&el=desc) will **decrease** coverage by `0.20%`.
> The diff coverage is `65.17%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
===========================================
- Coverage 67.46% 67.26% -0.21%
===========================================
Files 169 174 +5
Lines 8579 9261 +682
===========================================
+ Hits 5788 6229 +441
- Misses 2247 2428 +181
- Partials 544 604 +60
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <57.00%> (ø)` | |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `57.37% <57.37%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `72.34% <72.34%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `73.58% <73.58%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `52.54% <75.00%> (-0.03%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.04% <79.04%> (ø)` | |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `72.34% <85.71%> (-4.41%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `65.38% <100.00%> (+4.51%)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [d7a37ba...d7a37ba](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] flycash commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "flycash (GitHub)" <gi...@apache.org>.
The invoker has locked. So it's not neccessary add lock here.
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "sxllwx (GitHub)" <gi...@apache.org>.
Yes, i fix in latest commit.
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
maybe ` s.currentWatcherId` should be atomic var.
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/cfbd042e0e6666308e53f3a1d56a1e52dab3764d?src=pr&el=desc) will **decrease** coverage by `0.46%`.
> The diff coverage is `65.6%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
=========================================
- Coverage 67.46% 67% -0.47%
=========================================
Files 169 174 +5
Lines 8579 9261 +682
=========================================
+ Hits 5788 6205 +417
- Misses 2247 2448 +201
- Partials 544 608 +64
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `65.38% <100%> (+4.51%)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `57.37% <57.37%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `59.81% <59.81%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `72.34% <72.34%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `73.58% <73.58%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `52.54% <75%> (-0.03%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.04% <79.04%> (ø)` | |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `72.34% <85.71%> (-4.41%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <0%> (-5.38%)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [cfbd042...46f5c9a](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/bf8bf85dc37399a23d124a7e6809c5c76ee90d49&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
========================================
Coverage 67.19% 67.19%
========================================
Files 167 167
Lines 9013 9013
========================================
Hits 6056 6056
Misses 2376 2376
Partials 581 581
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [bf8bf85...bf8bf85](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **decrease** coverage by `0.1%`.
> The diff coverage is `64.66%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
===========================================
- Coverage 67.03% 66.93% -0.11%
===========================================
Files 161 167 +6
Lines 8331 9013 +682
===========================================
+ Hits 5585 6033 +448
- Misses 2222 2397 +175
- Partials 524 583 +59
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `57.81% <57.81%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `60.55% <60.55%> (ø)` | |
| [remoting/kubernetes/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9mYWNhZGUuZ28=) | `65.62% <65.62%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `70.42% <70.42%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `76.74% <76.74%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80.95% <80.95%> (ø)` | |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `93.06% <0%> (-2.81%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [a7ae33f...b9bf7d9](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
Stopped Watcher? I can not understand what its meaning is.
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/cfbd042e0e6666308e53f3a1d56a1e52dab3764d?src=pr&el=desc) will **decrease** coverage by `0.37%`.
> The diff coverage is `64.73%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
===========================================
- Coverage 67.46% 67.08% -0.38%
===========================================
Files 169 174 +5
Lines 8579 9261 +682
===========================================
+ Hits 5788 6213 +425
- Misses 2247 2442 +195
- Partials 544 606 +62
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `65.38% <100%> (+4.51%)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57% <57%> (ø)` | |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `57.37% <57.37%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `72.34% <72.34%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `73.58% <73.58%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `52.54% <75%> (-0.03%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `76.19% <76.19%> (ø)` | |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `72.34% <85.71%> (-4.41%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0%> (-10.15%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [cfbd042...b88cf66](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
firstly, I hate give a var name of the return value in func definition. Secondly, If u really like to use it, pls give them some useful names. err -> retError, fox example.
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `64.97%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
===========================================
- Coverage 67.03% 66.77% -0.27%
===========================================
Files 161 166 +5
Lines 8331 8999 +668
===========================================
+ Hits 5585 6009 +424
- Misses 2222 2410 +188
- Partials 524 580 +56
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57% <57%> (ø)` | |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.03% <58.03%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `73.58% <73.58%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `76.74% <76.74%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80% <80%> (ø)` | |
| [filter/filter\_impl/metrics\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL21ldHJpY3NfZmlsdGVyLmdv) | `86.36% <0%> (-13.64%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `64.24% <0%> (-4.85%)` | :arrow_down: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `93.06% <0%> (-2.81%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [a7ae33f...8773a7d](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] flycash closed pull request #400: Add: kubernetes
registry and remote package unit test
Posted by "flycash (GitHub)" <gi...@apache.org>.
[ pull request closed by flycash ]
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on issue #400: Add: kubernetes
registry and remote package unit test
Posted by "sxllwx (GitHub)" <gi...@apache.org>.
> @sxllwx pls check the travis.
I had resovle this bug in last commit~
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a47cf7384eb54c6e1dfd7a464723f37dd5067acf&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
========================================
Coverage 67.00% 67.00%
========================================
Files 174 174
Lines 9261 9261
========================================
Hits 6205 6205
Misses 2448 2448
Partials 608 608
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [a47cf73...a47cf73](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "sxllwx (GitHub)" <gi...@apache.org>.
Yes, i already resolve it
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] flycash commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "flycash (GitHub)" <gi...@apache.org>.
return c.rawClient != nil
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "zouyx (GitHub)" <gi...@apache.org>.
[Detail golang module rule](https://github.com/golang/go/wiki/Modules#semantic-import-versioning%EF%BC%8C)
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "sxllwx (GitHub)" <gi...@apache.org>.
the k8s.io/api was depended by client-go.
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `64.97%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
===========================================
- Coverage 67.03% 66.77% -0.27%
===========================================
Files 161 166 +5
Lines 8331 8999 +668
===========================================
+ Hits 5585 6009 +424
- Misses 2222 2410 +188
- Partials 524 580 +56
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57% <57%> (ø)` | |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.03% <58.03%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `73.58% <73.58%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `76.74% <76.74%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80% <80%> (ø)` | |
| [filter/filter\_impl/metrics\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL21ldHJpY3NfZmlsdGVyLmdv) | `86.36% <0%> (-13.64%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `64.24% <0%> (-4.85%)` | :arrow_down: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `93.06% <0%> (-2.81%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [a7ae33f...1ed3e91](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/088625775848fd99a9bf62a8779ac8008b3d3ef8&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
========================================
Coverage 67.09% 67.09%
========================================
Files 167 167
Lines 9013 9013
========================================
Hits 6047 6047
Misses 2382 2382
Partials 584 584
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [0886257...0886257](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "zouyx (GitHub)" <gi...@apache.org>.
Pakcage ```version``` should use ```version+incompatible```, dont use ```commitid+ timestamp```
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `65.68%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
===========================================
- Coverage 67.03% 67.01% -0.03%
===========================================
Files 161 167 +6
Lines 8331 9010 +679
===========================================
+ Hits 5585 6038 +453
- Misses 2222 2390 +168
- Partials 524 582 +58
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `57.81% <57.81%> (ø)` | |
| [remoting/kubernetes/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9mYWNhZGUuZ28=) | `65.62% <65.62%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `66.99% <66.99%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `70.42% <70.42%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `76.74% <76.74%> (ø)` | |
| [remoting/kubernetes/store.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9zdG9yZS5nbw==) | `80.55% <80.55%> (ø)` | |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `93.06% <0%> (-2.81%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [a7ae33f...c7474fa](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "zouyx (GitHub)" <gi...@apache.org>.
don't use ```rm``` , no ```rm``` command in windows.........
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] sxllwx commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "sxllwx (GitHub)" <gi...@apache.org>.
Yeah, it's a wrong comment.
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #400: Add:
kubernetes registry and remote package unit test
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=h1) Report
> Merging [#400](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a7ae33fae5505c4e727c5f3052d5bbc92b2a7683?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `64.43%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #400 +/- ##
=========================================
- Coverage 67.03% 67% -0.04%
=========================================
Files 161 167 +6
Lines 8331 9004 +673
=========================================
+ Hits 5585 6033 +448
- Misses 2222 2388 +166
- Partials 524 583 +59
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <100%> (ø)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `57.46% <57.46%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `61.16% <61.16%> (ø)` | |
| [remoting/kubernetes/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9mYWNhZGUuZ28=) | `65.62% <65.62%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `70.42% <70.42%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `76.74% <76.74%> (ø)` | |
| [remoting/kubernetes/store.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9zdG9yZS5nbw==) | `78.5% <78.5%> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `35.29% <0%> (-29.42%)` | :arrow_down: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `93.06% <0%> (-2.81%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/dubbo-go/pull/400/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=footer). Last update [a7ae33f...c7474fa](https://codecov.io/gh/apache/dubbo-go/pull/400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] flycash commented on pull request #400: Add:
kubernetes registry and remote package unit test
Posted by "flycash (GitHub)" <gi...@apache.org>.
In double-check, you don't need any lock here.
[ Full content available at: https://github.com/apache/dubbo-go/pull/400 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org