You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/30 04:16:48 UTC
[kudu-CR](branch-1.11.x) [client] fix doxygen warnings
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14583
to review the following change.
Change subject: [client] fix doxygen warnings
......................................................................
[client] fix doxygen warnings
This patch doesn't contain any functional modifications.
Change-Id: Ife1c154064482db07dcc6ec4b760cc30055df13e
Reviewed-on: http://gerrit.cloudera.org:8080/14581
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit 0870259456f785c4efdf5826350166d8d6dff5cc)
---
M src/kudu/client/client.h
M src/kudu/client/schema.h
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/14583/1
--
To view, visit http://gerrit.cloudera.org:8080/14583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife1c154064482db07dcc6ec4b760cc30055df13e
Gerrit-Change-Number: 14583
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) [client] fix doxygen warnings
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [client] fix doxygen warnings
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ife1c154064482db07dcc6ec4b760cc30055df13e
Gerrit-Change-Number: 14583
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) [client] fix doxygen warnings
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14583 )
Change subject: [client] fix doxygen warnings
......................................................................
Patch Set 1: Verified+1
Unrelated test failures due to non-synchronized clock.
--
To view, visit http://gerrit.cloudera.org:8080/14583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife1c154064482db07dcc6ec4b760cc30055df13e
Gerrit-Change-Number: 14583
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Oct 2019 05:49:52 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.11.x) [client] fix doxygen warnings
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14583 )
Change subject: [client] fix doxygen warnings
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife1c154064482db07dcc6ec4b760cc30055df13e
Gerrit-Change-Number: 14583
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Oct 2019 04:21:42 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.11.x) [client] fix doxygen warnings
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14583 )
Change subject: [client] fix doxygen warnings
......................................................................
[client] fix doxygen warnings
This patch doesn't contain any functional modifications.
Change-Id: Ife1c154064482db07dcc6ec4b760cc30055df13e
Reviewed-on: http://gerrit.cloudera.org:8080/14581
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit 0870259456f785c4efdf5826350166d8d6dff5cc)
Reviewed-on: http://gerrit.cloudera.org:8080/14583
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/client/client.h
M src/kudu/client/schema.h
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife1c154064482db07dcc6ec4b760cc30055df13e
Gerrit-Change-Number: 14583
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)