[PR] fix(litetopic): exclude unrelated group clients from summaries [rocketmq-dashboard]

["X-LightYear (via GitHub)" <gi...@apache.org>]

X-LightYear opened a new pull request, #7203:
URL: https://github.com/apache/rocketmq-dashboard/pull/7203

   ## Summary
   
   - count only clients subscribed to the selected LiteTopic parent in list summaries
   - keep unrelated clients in the same consumer group out of `consumerCount` and `sessionIds`
   - add deterministic provider regression coverage
   
   ## Root cause
   
   `RocketMQLiteTopicProvider.buildSummary` counted every connection returned for a consumer group before checking the parent-scoped `getLiteClientInfo` result. A group can contain clients that are not subscribed to the selected LiteTopic parent.
   
   ## Fix
   
   Resolve the parent-scoped client information first and add a client to the summary only when it reports at least one LiteTopic under that parent. A valid subscription with an unavailable last-access timestamp remains counted.
   
   ## Testing
   
   - `mvn -B -ntp -Dmaven.compiler.proc=full -Dtest=RocketMQLiteTopicProviderTest test`
   - pre-fix regression: expected `consumerCount=1`, actual `2`
   - post-fix: 28 tests passed
   
   Fixes #7202
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(litetopic): exclude unrelated group clients from summaries [rocketmq-dashboard]

["lizhimins (via GitHub)" <gi...@apache.org>]

lizhimins commented on PR #7203:
URL: https://github.com/apache/rocketmq-dashboard/pull/7203#issuecomment-6448428813

   Merged as part of #7188 - squashed into `rocketmq-studio` as `7f2dfd3ed`.
   
   Your change here (counting only the clients that actually have lite topics under the parent topic in buildSummary, so the consumer count stops including clients connected to the group but unrelated to this parent) is included. Resolving the client once also let the separate clientLastAccess lookup go away, since the same record carries lastAccessTime.
   
   We grouped 2 of your related fixes into a single commit so the trunk history stays reviewable. Everything was cherry-picked onto the current baseline with you kept as the author, and your tests came along with the change - removing the lite-topic filter fails listLiteTopicsShouldCountOnlyClientsSubscribedToTheParentTopicTest, so the behaviour is pinned.
   
   Note that #7344 is still open and adds a test at the same point in RocketMQLiteTopicProviderTest, so it will need a rebase onto this. Thanks for the patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(litetopic): exclude unrelated group clients from summaries [rocketmq-dashboard]

["lizhimins (via GitHub)" <gi...@apache.org>]

lizhimins closed pull request #7203: fix(litetopic): exclude unrelated group clients from summaries
URL: https://github.com/apache/rocketmq-dashboard/pull/7203


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org